Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storagenode): support aws rds instance #314

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

Xu-Wentao
Copy link
Collaborator

@Xu-Wentao Xu-Wentao commented Apr 17, 2023

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

  • support auto manage aws rds instance from StorageNode and DatabaseClass

there are some things need to be done in the future:

  • Handle finalize resource logic, when instance is being deleting, we need to retain the storage node resource and waiting for instance be deleted.
  • Enum aws instance status
  • add more options for StorageNode annotations to set personal settings of DatabaseClass
    • masterUsername
    • generateMasterUserPassword and save the password to somewhere
    • some delete options like backup and snapshot
  • add more test cases

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?

@Xu-Wentao Xu-Wentao marked this pull request as draft April 17, 2023 11:04
@Xu-Wentao Xu-Wentao changed the title Draft: feat(storagenode): support aws rds instance WIP: feat(storagenode): support aws rds instance Apr 17, 2023
@Xu-Wentao Xu-Wentao force-pushed the feat/storage-node branch 17 times, most recently from f092f45 to d26fd99 Compare April 20, 2023 10:22
@Xu-Wentao Xu-Wentao changed the title WIP: feat(storagenode): support aws rds instance feat(storagenode): support aws rds instance Apr 20, 2023
@Xu-Wentao Xu-Wentao marked this pull request as ready for review April 20, 2023 10:23
@mlycore mlycore added type: enhancement New feature or request operator solutions of operator labels Apr 20, 2023
@mlycore mlycore added this to the 0.3.0 milestone Apr 20, 2023
@mlycore
Copy link
Contributor

mlycore commented Apr 20, 2023

LGTM

@mlycore
Copy link
Contributor

mlycore commented Apr 20, 2023

Backup with snapshot is a key feature to StorageNode. Here's a new issue and let's discuss there.

@mlycore
Copy link
Contributor

mlycore commented Apr 20, 2023

#317

@mlycore mlycore merged commit 17aa43a into apache:feat-storagenode Apr 20, 2023
Xu-Wentao added a commit to Xu-Wentao/shardingsphere-on-cloud that referenced this pull request May 5, 2023
Xu-Wentao added a commit to Xu-Wentao/shardingsphere-on-cloud that referenced this pull request May 6, 2023
Xu-Wentao added a commit to Xu-Wentao/shardingsphere-on-cloud that referenced this pull request May 6, 2023
Xu-Wentao added a commit to Xu-Wentao/shardingsphere-on-cloud that referenced this pull request May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
operator solutions of operator type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants