Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage-node): fix get username and password from dbClass #386

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

yikuaibro
Copy link
Contributor

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

fix #292 (comment) - the first point

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?

@github-actions github-actions bot added the operator solutions of operator label Jun 1, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yikuaibro
Copy link
Contributor Author

@Xu-Wentao help review

@codecov-commenter
Copy link

Codecov Report

Merging #386 (1b50b85) into main (e52f093) will decrease coverage by 1.56%.
The diff coverage is 5.26%.

@@            Coverage Diff             @@
##             main     #386      +/-   ##
==========================================
- Coverage   47.34%   45.78%   -1.56%     
==========================================
  Files          48       49       +1     
  Lines        5264     5452     +188     
==========================================
+ Hits         2492     2496       +4     
- Misses       2547     2731     +184     
  Partials      225      225              
Impacted Files Coverage Δ
pitr/cli/internal/cmd/backup.go 73.47% <0.00%> (ø)
...tor/cmd/shardingsphere-operator/manager/manager.go 0.00% <ø> (ø)
...perator/pkg/controllers/compute_node_controller.go 0.00% <0.00%> (ø)
...phere-operator/pkg/controllers/proxy_controller.go 0.00% <ø> (ø)
...operator/pkg/controllers/proxyconfig_controller.go 0.00% <ø> (ø)
...pkg/controllers/shardingsphere_chaos_controller.go 46.46% <ø> (ø)
...operator/pkg/distsql/visitor/shadow_rdl_visitor.go 0.00% <0.00%> (ø)
...operator/pkg/reconcile/computenode/compute_node.go 38.29% <50.00%> (ø)
...perator/pkg/controllers/storage_node_controller.go 55.85% <87.50%> (+0.40%) ⬆️
...ator/cmd/shardingsphere-operator/manager/option.go 49.52% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mlycore mlycore added type: enhancement New feature or request in: storagenode modules of storagenode labels Jun 1, 2023
@mlycore mlycore added this to the 0.3.0 milestone Jun 1, 2023
@mlycore mlycore merged commit c9473aa into apache:main Jun 1, 2023
@yikuaibro yikuaibro deleted the db_class branch June 15, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: storagenode modules of storagenode operator solutions of operator type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DISCUSS] Introduce new CRD as StorageNode for better usability
3 participants