Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Switch Btn to adjust plugin screen alignment #275

Merged
merged 6 commits into from
Apr 14, 2023

Conversation

dev-ST-IA
Copy link
Contributor

@dev-ST-IA dev-ST-IA commented Apr 5, 2023

Implements #274

@dev-ST-IA
Copy link
Contributor Author

Hi, apologies for the build failures, allow me to review the failures and refactor the code, I'll update my PR asap, thanks

@yu199195
Copy link
Member

yu199195 commented Apr 7, 2023

Looking forward to your update.

li-keguo
li-keguo previously approved these changes Apr 8, 2023
<Title level={3} type="secondary" style={{margin:0}}>{role}</Title>
</div>
<div style={{ display: 'flex',alignItems:'end',gap:10 }}>
<Switch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Maybe you should add events that you can modify.
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tip.
I can attempt on it, can I get some more idea on it, I didn't quite get an understanding on what you mentioned

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

The switch button is used to quickly enable and disable plug-ins.
You can do this using the editing interface.[plugin/update]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, currently the switch can't be toggled ,it can only be changed by clicking edit and changing the status in the modal.
Should I allow changing the status by clicking the switch?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes,
You can also replace them with tags so you don't have to add modification events

image

@dev-ST-IA
Copy link
Contributor Author

dev-ST-IA commented Apr 14, 2023

Hi, Sorry for the late update
I made the following change, I hope this is what was requested from you. I added an OnChange event to the switch and added a tag to indicate the status. I also removed the text in switch as there is a tag.
Screenshot from 2023-04-14 17-17-56
Screenshot from 2023-04-14 17-18-29

please feel free to review it, if this wasn't expected, I'm willing to make any relevant changes as requested, dont worry
thank you

@li-keguo li-keguo merged commit 5015557 into apache:master Apr 14, 2023
@li-keguo
Copy link
Member

Thank you very much for your contribution.

@li-keguo li-keguo added the type: enhancement New feature or request label Apr 14, 2023
@li-keguo
Copy link
Member

You should sync this feature to the admin resource.

see : https://github.com/apache/shenyu/tree/master/shenyu-admin/src/main/resources/static

Thanks~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants