Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: optimization of json field format in the form #292

Merged
merged 14 commits into from
Jul 18, 2023
Merged

refactor: optimization of json field format in the form #292

merged 14 commits into from
Jul 18, 2023

Conversation

eurecalulu
Copy link
Contributor

@eurecalulu eurecalulu commented Jul 15, 2023

This PR mainly made the following changes:

  • Add the function of "copy selector":
复制选择器
  • Add the function of "delete discovery":
delete
  • Modify the fields of "discovery props", "selector props", and "handler": change the original text area to the current specific field
  1. discovery config:
discovery
  1. proxy-selector config:
selector1 selector2

@ywj1352 ywj1352 requested a review from li-keguo July 18, 2023 09:39
@@ -429,6 +434,7 @@ class AddModal extends Component {
if (customRulePage) {
RuleHandleComponent = PluginRuleHandle[pluginName];
} else if (pluginHandleList) {
console.log("I'm here")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The debug log should be commented out or deleted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry😭I've deleted just now. Thank you for your patience~

@li-keguo li-keguo merged commit 2dbc47f into apache:master Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants