Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new feature: quickly add records by copying on the /config/pluginhandle page #324

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

kerwin612
Copy link
Member

image

@li-keguo
Copy link
Member

This looks pretty good. But I have a question. Why add this feature? How does the replication step work? Will it lead to duplicate data? Looking forward to your reply

@kerwin612
Copy link
Member Author

This looks pretty good. But I have a question. Why add this feature? How does the replication step work? Will it lead to duplicate data? Looking forward to your reply

From the experience after actual use, several pages of /config/pluginhandle/config/metadata/config/dict have similar troubles.
Such as page /config/pluginhandle, a plug may need to add multiple fields, only the field names and descriptions are different.
In practice, I Every time add, need to select the PluginName, select the DataType, and select the FieldType to which the field belongs;
And add by copying, I only need to modify the name and description; Eliminates a lot of selection operations (selection is a costly operation and time consuming);

Realizing logic and editing is a logic; first query the details of the selected record, and then delete the ID; call the add-api when saving; there will be no duplicate data, if there is such a situation, it is also The backend API needs to be prevented;

@kerwin612
Copy link
Member Author

If you agree and merge this PR, then I will add this feature to the /config/metadata and /config/dict pages.

@li-keguo li-keguo merged commit 20f2a06 into apache:master Aug 25, 2023
5 checks passed
@kerwin612 kerwin612 deleted the patch-4 branch August 25, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants