New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Optimization] Optimizing PromiseRender.js Deprecated React Lifecycle #349

Merged

li-keguo merged 1 commit into apache:master from VampireAchao:apache-master-patch-5

Oct 6, 2023

Contributor

VampireAchao commented Oct 3, 2023

see: #341

see: https://legacy.reactjs.org/blog/2018/03/27/update-on-async-rendering.html#fetching-external-data-when-props-change

The recommended upgrade path for this component is to move data updates into componentDidUpdate. You can also use the new getDerivedStateFromProps lifecycle to clear stale data before rendering the new props


          [Optimization] Optimizing PromiseRender.js Deprecated React Lifecycle

6c0e3c2

VampireAchao mentioned this pull request

[Task] [Optimization] Optimizing Deprecated React Lifecycle #341

Closed

18 tasks

li-keguo approved these changes

View reviewed changes

li-keguo merged commit 6e5bc8e into apache:master

5 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet