New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Optimization] Optimizing CountDown Component Deprecated React Lifecycle #358

Merged

dengliming merged 2 commits into apache:master from VampireAchao:apache-master-patch-10

Oct 15, 2023

Contributor

VampireAchao commented Oct 15, 2023

issue：#341

Moved initTime - Now it's a standalone function, not in the class
Ditched componentWillReceiveProps - Swapped with getDerivedStateFromProps
Safe State Updates - Added a tiny setTimeout in componentDidUpdate to manage state changes safely
Timer Management - Ensured all timers get cleared when the component says goodbye
Clean & Clear - Aimed for code that’s easy to read and understand

All cleaned up and following React's guidelines 🚀👍👀


          [Optimization] Optimizing CountDown Component Deprecated React Lifecycle

f9d38f3

VampireAchao mentioned this pull request

[Task] [Optimization] Optimizing Deprecated React Lifecycle #341

Closed

18 tasks


          [Improve] Improve error messaging and value assignment

6e7233a

dengliming approved these changes

View reviewed changes

dengliming merged commit eece936 into apache:master

5 checks passed

dengliming added the type: enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement