[SPARK-54030][SQL] Add user-friendly assertion message for view metadata corruption

### What changes were proposed in this pull request?

This PR enhances error reporting for corrupted view metadata by adding a detailed, user-friendly assertion message when there's a mismatch between the number of view query column names and the number of columns in the view schema.
Changes:
Enhanced the assertion in SessionCatalog.scala (fromCatalogTable method) to include:
The fully qualified view name
The actual number of view query column names vs schema columns
The list of view query column names
The list of view schema column names
Guidance that the metadata needs to be repaired
Added a unit test in SessionCatalogSuite.scala to verify the enhanced error message is displayed correctly when corrupted view metadata is detected.

### Why are the changes needed?

Currently, when view metadata is corrupted (i.e., the number of view query column names doesn't match the schema length), the assertion fails with a generic "assertion failed" message that provides no context about:
Which view has the problem
What the actual vs expected values are
What columns are involved
How to fix the issue
This makes debugging production issues very difficult. The enhanced error message provides all the necessary information to quickly identify and repair the corrupted view metadata.

### Does this PR introduce _any_ user-facing change?

Yes. Users will now see a detailed error message instead of a generic assertion failure when encountering corrupted view metadata:

Before:
`assertion failed`

After:
`assertion failed: Corrupted view metadata detected for view spark_catalog.db.view_name.
The number of view query column names 2 does not match the number of columns in the view schema 3.
View query column names: [id, name], View schema columns: [id, name, value].
This indicates corrupted view metadata that needs to be repaired.`

### How was this patch tested?

Added a new unit test corrupted view metadata: mismatch between viewQueryColumnNames and schema in SessionCatalogSuite.scala that:
Creates a view with intentionally corrupted metadata (2 query column names but 3 schema columns)
Verifies that looking up the view throws an AssertionError
Validates the error message contains all expected details
Existing tests continue to pass

### Was this patch authored or co-authored using generative AI tooling?

No

Closes #52732 from ganeshashree/SPARK-54030.

Authored-by: Ganesha S <ganesha.s@databricks.com>
Signed-off-by: Wenchen Fan <wenchen@databricks.com>

Author: ganeshas-db

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala

@@ -1031,7 +1031,16 @@ class SessionCatalog(
           // output is the same with the view output.
           metadata.schema.fieldNames.toImmutableArraySeq
         } else {
-          assert(metadata.viewQueryColumnNames.length == metadata.schema.length)
+          assert(metadata.viewQueryColumnNames.length == metadata.schema.length,
+            "Corrupted view metadata detected for view " +
+            metadata.identifier.quotedString + ". " +
+            "The number of view query column names " +
+            metadata.viewQueryColumnNames.length + " " +
+            "does not match the number of columns in the view schema " +
+            metadata.schema.length + ". " +
+            "View query column names: [" + metadata.viewQueryColumnNames.mkString(", ") + "], " +
+            "View schema columns: [" + metadata.schema.fieldNames.mkString(", ") + "]. " +
+            "This indicates corrupted view metadata that needs to be repaired.")
           metadata.viewQueryColumnNames
         }
 

sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala

@@ -2026,4 +2026,69 @@ abstract class SessionCatalogSuite extends AnalysisTest with Eventually {
     assert(partitionSchema.fieldNames.toSeq == Seq("year", "month"))
     assert(partitionSchema.fields.length == 2)
   }
+
+  test("corrupted view metadata: mismatch between viewQueryColumnNames and schema") {
+    withSQLConf("spark.sql.viewSchemaBinding.enabled" -> "true") {
+      val catalog = new SessionCatalog(newBasicCatalog())
+      val db = "test_db"
+      catalog.createDatabase(newDb(db), ignoreIfExists = false)
+
+      // First create a base table for the view to reference
+      val baseTable = CatalogTable(
+        identifier = TableIdentifier("base_table", Some(db)),
+        tableType = CatalogTableType.MANAGED,
+        storage = CatalogStorageFormat.empty,
+        schema = new StructType()
+          .add("id", IntegerType)
+          .add("name", StringType)
+          .add("value", DoubleType)
+      )
+      catalog.createTable(baseTable, ignoreIfExists = false)
+
+      // Create a view with corrupted metadata where viewQueryColumnNames length
+      // doesn't match schema length
+      // We need to set the properties to define viewQueryColumnNames
+      val properties = Map(
+        "view.query.out.numCols" -> "2",
+        "view.query.out.col.0" -> "id",
+        "view.query.out.col.1" -> "name",
+        "view.schema.mode" -> "binding"  // Ensure it's not SchemaEvolution
+      )
+      val corruptedView = CatalogTable(
+        identifier = TableIdentifier("corrupted_view", Some(db)),
+        tableType = CatalogTableType.VIEW,
+        storage = CatalogStorageFormat.empty,
+        schema = new StructType()
+          .add("id", IntegerType)
+          .add("name", StringType)
+          .add("value", DoubleType),
+        viewText = Some("SELECT * FROM test_db.base_table"),
+        provider = Some("spark"),  // Ensure it's not Hive-created
+        properties = properties  // Only 2 query column names but schema has 3 columns
+      )
+
+      catalog.createTable(corruptedView, ignoreIfExists = false)
+
+      // Verify the view was created with corrupted metadata
+      val retrievedView = catalog.getTableMetadata(TableIdentifier("corrupted_view", Some(db)))
+      assert(retrievedView.viewQueryColumnNames.length == 2)
+      assert(retrievedView.schema.length == 3)
+
+      // Attempting to look up the view should throw an assertion error with detailed message
+      val exception = intercept[AssertionError] {
+        catalog.lookupRelation(TableIdentifier("corrupted_view", Some(db)))
+      }
+
+      // The expected message pattern allows for optional catalog prefix
+      val expectedPattern =
+        "assertion failed: Corrupted view metadata detected for view " +
+        "(\\`\\w+\\`\\.)?\\`test_db\\`\\.\\`corrupted_view\\`\\. " +
+        "The number of view query column names 2 " +
+        "does not match the number of columns in the view schema 3\\. " +
+        "View query column names: \\[id, name\\], " +
+        "View schema columns: \\[id, name, value\\]\\. " +
+        "This indicates corrupted view metadata that needs to be repaired\\."
+      assert(exception.getMessage.matches(expectedPattern))
+    }
+  }
 }