From 2cb9d814fded6b6bafa0a046a30060455069ddc6 Mon Sep 17 00:00:00 2001 From: WeichenXu Date: Sat, 9 Jul 2016 23:07:13 -0700 Subject: [PATCH 1/2] add linear regression training not convergence warning --- .../org/apache/spark/ml/regression/LinearRegression.scala | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala b/mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala index 0a4d98cab64a..10d65bed807b 100644 --- a/mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala +++ b/mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala @@ -327,6 +327,11 @@ class LinearRegression @Since("1.3.0") (@Since("1.3.0") override val uid: String throw new SparkException(msg) } + if (!state.actuallyConverged) { + logWarning("LinearRegression training fininshed but the result is not converged, " + + "the reason is: " + state.convergedReason.get.reason) + } + /* The coefficients are trained in the scaled space; we're converting them back to the original space. From 36dadb2a51f0e20d0999d46f06d9fc05d6e0e5ef Mon Sep 17 00:00:00 2001 From: WeichenXu Date: Sun, 10 Jul 2016 03:49:56 -0700 Subject: [PATCH 2/2] minor update --- .../org/apache/spark/ml/regression/LinearRegression.scala | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala b/mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala index 10d65bed807b..a598be076059 100644 --- a/mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala +++ b/mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala @@ -328,8 +328,8 @@ class LinearRegression @Since("1.3.0") (@Since("1.3.0") override val uid: String } if (!state.actuallyConverged) { - logWarning("LinearRegression training fininshed but the result is not converged, " + - "the reason is: " + state.convergedReason.get.reason) + logWarning("LinearRegression training fininshed but the result " + + s"is not converged because: ${state.convergedReason.get.reason}") } /*