From 999bb6f339962a72c4230a641247682efe8202bb Mon Sep 17 00:00:00 2001 From: Tathagata Das Date: Tue, 25 Mar 2014 17:44:22 -0700 Subject: [PATCH] Made Spark use existing shaded ASM and removed Spark's ASM depedency. --- core/pom.xml | 4 ---- .../main/scala/org/apache/spark/util/ClosureCleaner.scala | 5 +++-- .../scala/org/apache/spark/graphx/util/BytecodeUtils.scala | 5 ++--- pom.xml | 5 ----- project/SparkBuild.scala | 1 - .../scala/org/apache/spark/repl/ExecutorClassLoader.scala | 4 ++-- 6 files changed, 7 insertions(+), 17 deletions(-) diff --git a/core/pom.xml b/core/pom.xml index 6d6d34f9ebdb..0fdf38010a80 100644 --- a/core/pom.xml +++ b/core/pom.xml @@ -76,10 +76,6 @@ org.xerial.snappy snappy-java - - org.ow2.asm - asm - com.twitter chill_${scala.binary.version} diff --git a/core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala b/core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala index 1df6b87fb073..850b5364311a 100644 --- a/core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala +++ b/core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala @@ -22,8 +22,9 @@ import java.lang.reflect.Field import scala.collection.mutable.Map import scala.collection.mutable.Set -import org.objectweb.asm.{ClassReader, ClassVisitor, MethodVisitor, Type} -import org.objectweb.asm.Opcodes._ +import com.esotericsoftware.reflectasm.shaded.org.objectweb.asm.{ClassReader, ClassVisitor, MethodVisitor, Type} +import com.esotericsoftware.reflectasm.shaded.org.objectweb.asm.Opcodes._ + import java.io.{InputStream, IOException, ByteArrayOutputStream, ByteArrayInputStream, BufferedInputStream} import org.apache.spark.Logging diff --git a/graphx/src/main/scala/org/apache/spark/graphx/util/BytecodeUtils.scala b/graphx/src/main/scala/org/apache/spark/graphx/util/BytecodeUtils.scala index d1528e2f07cf..a05de313f99e 100644 --- a/graphx/src/main/scala/org/apache/spark/graphx/util/BytecodeUtils.scala +++ b/graphx/src/main/scala/org/apache/spark/graphx/util/BytecodeUtils.scala @@ -23,9 +23,8 @@ import scala.collection.mutable.HashSet import org.apache.spark.util.Utils -import org.objectweb.asm.{ClassReader, ClassVisitor, MethodVisitor} -import org.objectweb.asm.Opcodes._ - +import com.esotericsoftware.reflectasm.shaded.org.objectweb.asm.{ClassReader, ClassVisitor, MethodVisitor} +import com.esotericsoftware.reflectasm.shaded.org.objectweb.asm.Opcodes._ /** * Includes an utility function to test whether a function accesses a specific attribute diff --git a/pom.xml b/pom.xml index efd492c25ac1..e82d9e8510f5 100644 --- a/pom.xml +++ b/pom.xml @@ -195,11 +195,6 @@ snappy-java 1.0.5 - - org.ow2.asm - asm - 4.0 - com.clearspring.analytics stream diff --git a/project/SparkBuild.scala b/project/SparkBuild.scala index c603c4bbde6f..52e894e25635 100644 --- a/project/SparkBuild.scala +++ b/project/SparkBuild.scala @@ -271,7 +271,6 @@ object SparkBuild extends Build { "commons-daemon" % "commons-daemon" % "1.0.10", // workaround for bug HADOOP-9407 "com.ning" % "compress-lzf" % "1.0.0", "org.xerial.snappy" % "snappy-java" % "1.0.5", - "org.ow2.asm" % "asm" % "4.0", "org.spark-project.akka" %% "akka-remote" % "2.2.3-shaded-protobuf" excludeAll(excludeNetty), "org.spark-project.akka" %% "akka-slf4j" % "2.2.3-shaded-protobuf" excludeAll(excludeNetty), "org.spark-project.akka" %% "akka-testkit" % "2.2.3-shaded-protobuf" % "test", diff --git a/repl/src/main/scala/org/apache/spark/repl/ExecutorClassLoader.scala b/repl/src/main/scala/org/apache/spark/repl/ExecutorClassLoader.scala index 3e171849e349..9bf7beec82cc 100644 --- a/repl/src/main/scala/org/apache/spark/repl/ExecutorClassLoader.scala +++ b/repl/src/main/scala/org/apache/spark/repl/ExecutorClassLoader.scala @@ -24,8 +24,8 @@ import java.util.concurrent.{Executors, ExecutorService} import org.apache.hadoop.conf.Configuration import org.apache.hadoop.fs.{FileSystem, Path} -import org.objectweb.asm._ -import org.objectweb.asm.Opcodes._ +import com.esotericsoftware.reflectasm.shaded.org.objectweb.asm._ +import com.esotericsoftware.reflectasm.shaded.org.objectweb.asm.Opcodes._ /**