From 1b1c0a00f9564172916a6a3f6109a7ee5808b9fe Mon Sep 17 00:00:00 2001
From: shahid <shahidki31@gmail.com>
Date: Fri, 1 Nov 2019 10:32:45 +0530
Subject: [PATCH 1/2] support collapse table

---
 .../org/apache/spark/ui/static/webui.js       |  3 ++
 .../thriftserver/ui/ThriftServerPage.scala    | 40 +++++++++++++------
 .../ui/ThriftServerSessionPage.scala          | 16 +++++---
 3 files changed, 41 insertions(+), 18 deletions(-)

diff --git a/core/src/main/resources/org/apache/spark/ui/static/webui.js b/core/src/main/resources/org/apache/spark/ui/static/webui.js
index cf04db28804c..fac464e1353c 100644
--- a/core/src/main/resources/org/apache/spark/ui/static/webui.js
+++ b/core/src/main/resources/org/apache/spark/ui/static/webui.js
@@ -87,6 +87,9 @@ $(function() {
   collapseTablePageLoad('collapse-aggregated-runningExecutions','aggregated-runningExecutions');
   collapseTablePageLoad('collapse-aggregated-completedExecutions','aggregated-completedExecutions');
   collapseTablePageLoad('collapse-aggregated-failedExecutions','aggregated-failedExecutions');
+  collapseTablePageLoad('collapse-aggregated-sessionstat','aggregated-sessionstat');
+  collapseTablePageLoad('collapse-aggregated-sqlstat','aggregated-sqlstat');
+  collapseTablePageLoad('collapse-aggregated-sqlsessionstat','aggregated-sqlsessionstat');
 });
 
 $(function() {
diff --git a/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerPage.scala b/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerPage.scala
index 7258978e3bad..1740d3959b7c 100644
--- a/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerPage.scala
+++ b/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerPage.scala
@@ -125,15 +125,18 @@ private[ui] class ThriftServerPage(parent: ThriftServerTab) extends WebUIPage(""
     } else {
       None
     }
-
     val content =
-      <h5 id="sqlstat">SQL Statistics ({numStatement})</h5> ++
-        <div>
-          <ul class="unstyled">
-            {table.getOrElse("No statistics have been generated yet.")}
-          </ul>
+      <span id="running" class="collapse-aggregated-sqlstat collapse-tablestat"
+            onClick="collapseTable('collapse-aggregated-sqlstat',
+                'aggregated-sqlstat')">
+        <h4>
+          <span class="collapse-table-arrow arrow-open"></span>
+          <a>SQL Statistics ({numStatement})</a>
+        </h4>
+      </span> ++
+        <div class="aggregated-sqlstat collapsible-table">
+          {table.getOrElse("No statistics have been generated yet.")}
         </div>
-
     content
   }
 
@@ -165,13 +168,26 @@ private[ui] class ThriftServerPage(parent: ThriftServerTab) extends WebUIPage(""
     }
 
     val content =
-      <h5 id="sessionstat">Session Statistics ({numBatches})</h5> ++
-      <div>
-        <ul class="unstyled">
-          {table.getOrElse("No statistics have been generated yet.")}
-        </ul>
+    <span id="running" class="collapse-aggregated-sessionstat collapse-tablestat"
+          onClick="collapseTable('collapse-aggregated-sessionstat',
+                'aggregated-sessionstat')">
+      <h4>
+        <span class="collapse-table-arrow arrow-open"></span>
+        <a>Session Statistics ({numBatches})</a>
+      </h4>
+    </span> ++
+      <div class="aggregated-sessionstat collapsible-table">
+        {table.getOrElse("No statistics have been generated yet.")}
       </div>
 
+//    val content =
+//      <h5 id="sessionstat">Session Statistics ({numBatches})</h5> ++
+//      <div>
+//        <ul class="unstyled">
+//          {table.getOrElse("No statistics have been generated yet.")}
+//        </ul>
+//      </div>
+
     content
   }
 
diff --git a/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerSessionPage.scala b/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerSessionPage.scala
index 8b275f8f7be0..92e7cf7996a3 100644
--- a/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerSessionPage.scala
+++ b/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerSessionPage.scala
@@ -126,13 +126,17 @@ private[ui] class ThriftServerSessionPage(parent: ThriftServerTab)
     } else {
       None
     }
-
     val content =
-      <h5>SQL Statistics</h5> ++
-        <div>
-          <ul class="unstyled">
-            {table.getOrElse("No statistics have been generated yet.")}
-          </ul>
+      <span id="running" class="collapse-aggregated-sqlsessionstat collapse-tablestat"
+            onClick="collapseTable('collapse-aggregated-sqlsessionstat',
+                'aggregated-sqlsessionstat')">
+        <h4>
+          <span class="collapse-table-arrow arrow-open"></span>
+          <a>SQL Statistics</a>
+        </h4>
+      </span> ++
+        <div class="aggregated-sqlsessionstat collapsible-table">
+          {table.getOrElse("No statistics have been generated yet.")}
         </div>
 
     content

From 427158949f44bf6559dfe419a4c85f3722c70f59 Mon Sep 17 00:00:00 2001
From: shahid <shahidki31@gmail.com>
Date: Sun, 3 Nov 2019 03:41:53 +0530
Subject: [PATCH 2/2] fix

---
 .../spark/sql/hive/thriftserver/ui/ThriftServerPage.scala     | 4 ++--
 .../sql/hive/thriftserver/ui/ThriftServerSessionPage.scala    | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerPage.scala b/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerPage.scala
index 193dd541f405..eb5602b7a45f 100644
--- a/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerPage.scala
+++ b/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerPage.scala
@@ -125,7 +125,7 @@ private[ui] class ThriftServerPage(parent: ThriftServerTab) extends WebUIPage(""
       None
     }
     val content =
-      <span id="running" class="collapse-aggregated-sqlstat collapse-tablestat"
+      <span id="sqlstat" class="collapse-aggregated-sqlstat collapse-table"
             onClick="collapseTable('collapse-aggregated-sqlstat',
                 'aggregated-sqlstat')">
         <h4>
@@ -194,7 +194,7 @@ private[ui] class ThriftServerPage(parent: ThriftServerTab) extends WebUIPage(""
     }
 
     val content =
-    <span id="running" class="collapse-aggregated-sessionstat collapse-tablestat"
+    <span id="sessionstat" class="collapse-aggregated-sessionstat collapse-table"
           onClick="collapseTable('collapse-aggregated-sessionstat',
                 'aggregated-sessionstat')">
       <h4>
diff --git a/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerSessionPage.scala b/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerSessionPage.scala
index 92e7cf7996a3..aa2f495db565 100644
--- a/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerSessionPage.scala
+++ b/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerSessionPage.scala
@@ -127,7 +127,7 @@ private[ui] class ThriftServerSessionPage(parent: ThriftServerTab)
       None
     }
     val content =
-      <span id="running" class="collapse-aggregated-sqlsessionstat collapse-tablestat"
+      <span id="sqlsessionstat" class="collapse-aggregated-sqlsessionstat collapse-table"
             onClick="collapseTable('collapse-aggregated-sqlsessionstat',
                 'aggregated-sqlsessionstat')">
         <h4>