diff --git a/connector/connect/client/jvm/pom.xml b/connector/connect/client/jvm/pom.xml index 9bedebf523a79..81ffb140226e8 100644 --- a/connector/connect/client/jvm/pom.xml +++ b/connector/connect/client/jvm/pom.xml @@ -59,6 +59,18 @@ protobuf-java compile + + com.google.guava + guava + ${connect.guava.version} + compile + + + com.google.guava + failureaccess + ${guava.failureaccess.version} + compile + com.lihaoyi ammonite_${scala.version} @@ -105,6 +117,7 @@ true + com.google.guava:* com.google.android:* com.google.api.grpc:* com.google.code.findbugs:* @@ -124,6 +137,13 @@ + + com.google.common + ${spark.shade.packageName}.connect.guava + + com.google.common.** + + io.grpc ${spark.shade.packageName}.io.grpc @@ -135,7 +155,7 @@ com.google ${spark.shade.packageName}.com.google - + com.google.common.** diff --git a/connector/connect/common/pom.xml b/connector/connect/common/pom.xml index 336d83e04c151..b0f015246f4c9 100644 --- a/connector/connect/common/pom.xml +++ b/connector/connect/common/pom.xml @@ -47,23 +47,6 @@ com.google.protobuf protobuf-java - - - com.google.guava - guava - ${connect.guava.version} - compile - - - com.google.guava - failureaccess - ${guava.failureaccess.version} - compile - io.grpc grpc-netty @@ -158,17 +141,9 @@ org.spark-project.spark:unused - com.google.guava:guava - com.google.guava:failureaccess org.apache.tomcat:annotations-api - - - com.google.common - ${spark.shade.packageName}.connect.guava - - diff --git a/connector/connect/server/pom.xml b/connector/connect/server/pom.xml index 82127f736ccb8..bdea8a6270003 100644 --- a/connector/connect/server/pom.xml +++ b/connector/connect/server/pom.xml @@ -51,6 +51,12 @@ org.apache.spark spark-connect-common_${scala.binary.version} ${project.version} + + + com.google.guava + guava + + org.apache.spark @@ -150,6 +156,18 @@ org.scala-lang.modules scala-parallel-collections_${scala.binary.version} + + com.google.guava + guava + ${connect.guava.version} + compile + + + com.google.guava + failureaccess + ${guava.failureaccess.version} + compile + com.google.protobuf protobuf-java @@ -270,6 +288,7 @@ false + com.google.guava:* io.grpc:*: com.google.protobuf:* @@ -289,6 +308,13 @@ + + com.google.common + ${spark.shade.packageName}.connect.guava + + com.google.common.** + + com.google.thirdparty ${spark.shade.packageName}.connect.guava diff --git a/project/SparkBuild.scala b/project/SparkBuild.scala index 3123f931cd882..45b51cb0ff5b2 100644 --- a/project/SparkBuild.scala +++ b/project/SparkBuild.scala @@ -1487,7 +1487,11 @@ object CopyDependencies { if (destJar.isFile()) { destJar.delete() } - if (jar.getName.contains("spark-connect") && + + if (jar.getName.contains("spark-connect-common") && + !SbtPomKeys.profiles.value.contains("noshade-connect")) { + // Don't copy the spark connect common JAR as it is shaded in the spark connect. + } else if (jar.getName.contains("spark-connect") && !SbtPomKeys.profiles.value.contains("noshade-connect")) { Files.copy(fid.toPath, destJar.toPath) } else if (jar.getName.contains("connect-client-jvm") &&