[SPARK-49494][DOCS] Use spark logos from spark-website in docs #47966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @dongjoon-hyun @cloud-fan @HyukjinKwon, thank you |
There was a problem hiding this comment.
I'm wondering this is a safe way which is able to provide a recovery from the disaster, @yaooqinn .
For example, how can we recover our website when ASF Infra team lost the files at https://spark.apache.org/images/spark-logo-rev.svg ?
|
Thank you @dongjoon-hyun. I'm not using official logos in the infrastructure service of https://apache.org/logos since we have not fully uploaded all our logo variants to it. The https://spark.apache.org/images/spark-logo-rev.svg points to https://github.com/apache/spark-website/blob/asf-site/site/images/spark-logo-rev.svg which is a copy from https://github.com/apache/spark-website/blob/asf-site/images/spark-logo-rev.svg by jekyll build. I guess we handle these files ourselves. In this case, if the |
|
Maybe, I wasn't clear enough. What I meant was the case ASF website lost the disk and we need to republish our website cleanly. Let me rephrase my question more specifically. So, all deleted files of this PR are redundant ones because our
|
|
Yes, @dongjoon-hyun. The 'spark-website.git' has them |
|
Merged to master! Thank you. |
yaooqinn
added a commit
that referenced
this pull request
Sep 18, 2024
… via Live GitHub Pages Updates ### What changes were proposed in this pull request? This pull request introduces functionalities that enable 'Document and Feature Preview on the master branch via Live GitHub Pages Updates'. ### Why are the changes needed? - Instead of limited 72-hour voting phases, it provides the developer community with more opportunities to preview and verify the documentation contents. - Instead of waiting for the final announcement of an official spark feature release, users can now preview some of the ongoing documented features, increasing the willingness to upgrade, sensing breaking changes in advance, and reducing the burden during the final upgrades. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? An [example](https://yaooqinn.github.io/spark-gh-pages/) has been established by this repo - https://github.com/yaooqinn/spark-gh-pages - Broken logo links are fixed at #47966 ### Was this patch authored or co-authored using generative AI tooling? no Closes #47968 from yaooqinn/SPARK-49495. Authored-by: Kent Yao <yao@apache.org> Signed-off-by: Kent Yao <yao@apache.org>
yaooqinn
added a commit
to yaooqinn/spark
that referenced
this pull request
Sep 20, 2024
…h via Live GitHub Pages Updates
### What changes were proposed in this pull request?
This pull request introduces functionalities that enable 'Document and Feature Preview on the master branch via Live GitHub Pa
ges Updates'.
### Why are the changes needed?
- Instead of limited 72-hour voting phases, it provides the developer community with more opportunities to preview and verify
the documentation contents.
- Instead of waiting for the final announcement of an official spark feature release, users can now preview some of the ongoin
g documented features, increasing the willingness to upgrade, sensing breaking changes in advance, and reducing the burden during
the final upgrades.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
An [example](https://yaooqinn.github.io/spark-gh-pages/) has been established by this repo - https://github.com/yaooqinn/spark
-gh-pages
- Broken logo links are fixed at apache#47966
### Was this patch authored or co-authored using generative AI tooling?
no
IvanK-db
pushed a commit
to IvanK-db/spark
that referenced
this pull request
Sep 20, 2024
### What changes were proposed in this pull request? Use spark logos from spark-website in docs and remove them from spark main repo ### Why are the changes needed? - reduce spark-website incremental size - fix some cases when `/img/spark-logo-rev.svg` is invalid ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? doc build, https://github.com/yaooqinn/spark/actions/runs/10676269598/artifacts/1884295142 ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#47966 from yaooqinn/SPARK-49494. Authored-by: Kent Yao <yao@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
### What changes were proposed in this pull request? Use spark logos from spark-website in docs and remove them from spark main repo ### Why are the changes needed? - reduce spark-website incremental size - fix some cases when `/img/spark-logo-rev.svg` is invalid ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? doc build, https://github.com/yaooqinn/spark/actions/runs/10676269598/artifacts/1884295142 ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#47966 from yaooqinn/SPARK-49494. Authored-by: Kent Yao <yao@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
… via Live GitHub Pages Updates ### What changes were proposed in this pull request? This pull request introduces functionalities that enable 'Document and Feature Preview on the master branch via Live GitHub Pages Updates'. ### Why are the changes needed? - Instead of limited 72-hour voting phases, it provides the developer community with more opportunities to preview and verify the documentation contents. - Instead of waiting for the final announcement of an official spark feature release, users can now preview some of the ongoing documented features, increasing the willingness to upgrade, sensing breaking changes in advance, and reducing the burden during the final upgrades. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? An [example](https://yaooqinn.github.io/spark-gh-pages/) has been established by this repo - https://github.com/yaooqinn/spark-gh-pages - Broken logo links are fixed at apache#47966 ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#47968 from yaooqinn/SPARK-49495. Authored-by: Kent Yao <yao@apache.org> Signed-off-by: Kent Yao <yao@apache.org>
himadripal
pushed a commit
to himadripal/spark
that referenced
this pull request
Oct 19, 2024
### What changes were proposed in this pull request? Use spark logos from spark-website in docs and remove them from spark main repo ### Why are the changes needed? - reduce spark-website incremental size - fix some cases when `/img/spark-logo-rev.svg` is invalid ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? doc build, https://github.com/yaooqinn/spark/actions/runs/10676269598/artifacts/1884295142 ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#47966 from yaooqinn/SPARK-49494. Authored-by: Kent Yao <yao@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
himadripal
pushed a commit
to himadripal/spark
that referenced
this pull request
Oct 19, 2024
… via Live GitHub Pages Updates ### What changes were proposed in this pull request? This pull request introduces functionalities that enable 'Document and Feature Preview on the master branch via Live GitHub Pages Updates'. ### Why are the changes needed? - Instead of limited 72-hour voting phases, it provides the developer community with more opportunities to preview and verify the documentation contents. - Instead of waiting for the final announcement of an official spark feature release, users can now preview some of the ongoing documented features, increasing the willingness to upgrade, sensing breaking changes in advance, and reducing the burden during the final upgrades. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? An [example](https://yaooqinn.github.io/spark-gh-pages/) has been established by this repo - https://github.com/yaooqinn/spark-gh-pages - Broken logo links are fixed at apache#47966 ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#47968 from yaooqinn/SPARK-49495. Authored-by: Kent Yao <yao@apache.org> Signed-off-by: Kent Yao <yao@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use spark logos from spark-website in docs and remove them from spark main repo
Why are the changes needed?
/img/spark-logo-rev.svgis invalidDoes this PR introduce any user-facing change?
no
How was this patch tested?
doc build, https://github.com/yaooqinn/spark/actions/runs/10676269598/artifacts/1884295142
Was this patch authored or co-authored using generative AI tooling?
no