[SPARK-49709][CONNECT][SQL] Support ConfigEntry in the RuntimeConfig interface #49062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Thank you for polishing this 😄. I'm wondering what makes you change your mind. As you know, I raised some issues from the original PR, @hvanhovell . Anyway, +1 for this direction.
Removing them caused friction
hvanhovell
commented
Dec 4, 2024
| val conf = newConf() | ||
|
|
||
| val entry = SQLConf.FILES_MAX_PARTITION_NUM | ||
| assert(conf.get(entry.key) === null) |
There was a problem hiding this comment.
@HyukjinKwon @cloud-fan this returns null. I was expecting a NoSuchElementException here. IMO this is a bug. WDYT?
There was a problem hiding this comment.
yeah, i think it should. def get[T](entry: ConfigEntry[T]): T isn't an API so I think we should be fine with changing this behaviour too.
|
Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds support for ConfigEntry to the RuntimeConfig interface. This was removed in #47980.
Why are the changes needed?
This functionality is used a lot by Spark libraries. Removing them caused friction, and adding them does not pollute the RuntimeConfig interface.
Does this PR introduce any user-facing change?
No. This is developer API.
How was this patch tested?
I have added tests cases for Connect and Classic.
Was this patch authored or co-authored using generative AI tooling?
No.