diff --git a/examples/storm-elasticsearch-examples/pom.xml b/examples/storm-elasticsearch-examples/pom.xml
index 707d59daae7..f4faf60e182 100644
--- a/examples/storm-elasticsearch-examples/pom.xml
+++ b/examples/storm-elasticsearch-examples/pom.xml
@@ -98,7 +98,7 @@
maven-checkstyle-plugin
- 235
+ 20
diff --git a/examples/storm-hbase-examples/pom.xml b/examples/storm-hbase-examples/pom.xml
index 7fccde2898b..458d71daa45 100644
--- a/examples/storm-hbase-examples/pom.xml
+++ b/examples/storm-hbase-examples/pom.xml
@@ -89,7 +89,7 @@
maven-checkstyle-plugin
- 324
+ 55
diff --git a/examples/storm-hdfs-examples/pom.xml b/examples/storm-hdfs-examples/pom.xml
index 7a03bcb8b71..c2271fe6090 100644
--- a/examples/storm-hdfs-examples/pom.xml
+++ b/examples/storm-hdfs-examples/pom.xml
@@ -89,7 +89,7 @@
maven-checkstyle-plugin
- 557
+ 224
diff --git a/examples/storm-hive-examples/pom.xml b/examples/storm-hive-examples/pom.xml
index 87ec0233c47..c4cd8035bcd 100644
--- a/examples/storm-hive-examples/pom.xml
+++ b/examples/storm-hive-examples/pom.xml
@@ -89,7 +89,7 @@
maven-checkstyle-plugin
- 543
+ 67
diff --git a/examples/storm-jdbc-examples/pom.xml b/examples/storm-jdbc-examples/pom.xml
index 95ef67994d5..f65df945056 100644
--- a/examples/storm-jdbc-examples/pom.xml
+++ b/examples/storm-jdbc-examples/pom.xml
@@ -89,7 +89,7 @@
maven-checkstyle-plugin
- 188
+ 36
diff --git a/examples/storm-jms-examples/pom.xml b/examples/storm-jms-examples/pom.xml
index fc72bc998d7..db88127267e 100644
--- a/examples/storm-jms-examples/pom.xml
+++ b/examples/storm-jms-examples/pom.xml
@@ -117,7 +117,7 @@
maven-checkstyle-plugin
- 197
+ 78
diff --git a/examples/storm-kafka-client-examples/pom.xml b/examples/storm-kafka-client-examples/pom.xml
index 604dd13a56e..9c5796d1b71 100644
--- a/examples/storm-kafka-client-examples/pom.xml
+++ b/examples/storm-kafka-client-examples/pom.xml
@@ -136,7 +136,7 @@
maven-checkstyle-plugin
- 67
+ 2
diff --git a/examples/storm-kafka-examples/pom.xml b/examples/storm-kafka-examples/pom.xml
index 2afbe958a03..c3a1d6a8cd1 100644
--- a/examples/storm-kafka-examples/pom.xml
+++ b/examples/storm-kafka-examples/pom.xml
@@ -107,7 +107,7 @@
maven-checkstyle-plugin
- 190
+ 26
diff --git a/examples/storm-mongodb-examples/pom.xml b/examples/storm-mongodb-examples/pom.xml
index 85cecbdd038..980488c9d61 100644
--- a/examples/storm-mongodb-examples/pom.xml
+++ b/examples/storm-mongodb-examples/pom.xml
@@ -89,7 +89,7 @@
maven-checkstyle-plugin
- 349
+ 38
diff --git a/examples/storm-mqtt-examples/pom.xml b/examples/storm-mqtt-examples/pom.xml
index 415195ee3ca..ca7c41882ac 100644
--- a/examples/storm-mqtt-examples/pom.xml
+++ b/examples/storm-mqtt-examples/pom.xml
@@ -128,7 +128,7 @@
maven-checkstyle-plugin
- 82
+ 16
diff --git a/examples/storm-opentsdb-examples/pom.xml b/examples/storm-opentsdb-examples/pom.xml
index e177957d969..7f6364b3653 100644
--- a/examples/storm-opentsdb-examples/pom.xml
+++ b/examples/storm-opentsdb-examples/pom.xml
@@ -89,7 +89,7 @@
maven-checkstyle-plugin
- 147
+ 18
diff --git a/examples/storm-perf/pom.xml b/examples/storm-perf/pom.xml
index da0311f4006..7dc2579b0bc 100644
--- a/examples/storm-perf/pom.xml
+++ b/examples/storm-perf/pom.xml
@@ -81,7 +81,7 @@
maven-checkstyle-plugin
- 1179
+ 207
diff --git a/examples/storm-pmml-examples/pom.xml b/examples/storm-pmml-examples/pom.xml
index 58fb5194314..7fd181e9afb 100644
--- a/examples/storm-pmml-examples/pom.xml
+++ b/examples/storm-pmml-examples/pom.xml
@@ -79,7 +79,7 @@
maven-checkstyle-plugin
- 232
+ 17
diff --git a/examples/storm-redis-examples/pom.xml b/examples/storm-redis-examples/pom.xml
index ed89992197d..ededcce0aa9 100644
--- a/examples/storm-redis-examples/pom.xml
+++ b/examples/storm-redis-examples/pom.xml
@@ -89,7 +89,7 @@
maven-checkstyle-plugin
- 650
+ 54
diff --git a/examples/storm-rocketmq-examples/pom.xml b/examples/storm-rocketmq-examples/pom.xml
index 24fb3b15f46..772d1d058fa 100644
--- a/examples/storm-rocketmq-examples/pom.xml
+++ b/examples/storm-rocketmq-examples/pom.xml
@@ -89,7 +89,7 @@
maven-checkstyle-plugin
- 143
+ 23
diff --git a/examples/storm-solr-examples/pom.xml b/examples/storm-solr-examples/pom.xml
index 44c4f62f5d3..7926ff052db 100644
--- a/examples/storm-solr-examples/pom.xml
+++ b/examples/storm-solr-examples/pom.xml
@@ -89,7 +89,7 @@
maven-checkstyle-plugin
- 267
+ 47
diff --git a/examples/storm-starter/pom.xml b/examples/storm-starter/pom.xml
index 9725a595067..2ef18f27c65 100644
--- a/examples/storm-starter/pom.xml
+++ b/examples/storm-starter/pom.xml
@@ -251,7 +251,7 @@
maven-checkstyle-plugin
- 3064
+ 1538
diff --git a/external/storm-cassandra/pom.xml b/external/storm-cassandra/pom.xml
index 52f546925d3..2e728d40598 100644
--- a/external/storm-cassandra/pom.xml
+++ b/external/storm-cassandra/pom.xml
@@ -124,7 +124,7 @@
maven-checkstyle-plugin
- 2764
+ 577
diff --git a/external/storm-druid/pom.xml b/external/storm-druid/pom.xml
index 48a8b5678f7..43bfff22ed5 100644
--- a/external/storm-druid/pom.xml
+++ b/external/storm-druid/pom.xml
@@ -103,7 +103,7 @@
maven-checkstyle-plugin
- 193
+ 29
diff --git a/external/storm-elasticsearch/pom.xml b/external/storm-elasticsearch/pom.xml
index fe6f60b2eed..45b7d8d98b5 100644
--- a/external/storm-elasticsearch/pom.xml
+++ b/external/storm-elasticsearch/pom.xml
@@ -148,7 +148,7 @@
maven-checkstyle-plugin
- 792
+ 64
diff --git a/external/storm-eventhubs/pom.xml b/external/storm-eventhubs/pom.xml
index 5b39b8c8e99..080c46b7aaa 100755
--- a/external/storm-eventhubs/pom.xml
+++ b/external/storm-eventhubs/pom.xml
@@ -53,7 +53,7 @@
maven-checkstyle-plugin
- 1156
+ 1764
diff --git a/external/storm-hbase/pom.xml b/external/storm-hbase/pom.xml
index 9506918ed45..02d2e175184 100644
--- a/external/storm-hbase/pom.xml
+++ b/external/storm-hbase/pom.xml
@@ -106,7 +106,7 @@
maven-checkstyle-plugin
- 1572
+ 370
diff --git a/external/storm-hdfs/pom.xml b/external/storm-hdfs/pom.xml
index c8c97c9b2a3..9a81fdf1099 100644
--- a/external/storm-hdfs/pom.xml
+++ b/external/storm-hdfs/pom.xml
@@ -256,7 +256,7 @@
maven-checkstyle-plugin
- 3370
+ 2220
diff --git a/external/storm-hive/pom.xml b/external/storm-hive/pom.xml
index 33d023f37ec..1a6d3d07dcb 100644
--- a/external/storm-hive/pom.xml
+++ b/external/storm-hive/pom.xml
@@ -188,7 +188,7 @@
maven-checkstyle-plugin
- 1350
+ 259
diff --git a/external/storm-jdbc/pom.xml b/external/storm-jdbc/pom.xml
index 62ad926e948..759ddaed03b 100644
--- a/external/storm-jdbc/pom.xml
+++ b/external/storm-jdbc/pom.xml
@@ -92,7 +92,7 @@
maven-checkstyle-plugin
- 862
+ 149
diff --git a/external/storm-jms/pom.xml b/external/storm-jms/pom.xml
index 06033ce7f68..15323cb5c69 100644
--- a/external/storm-jms/pom.xml
+++ b/external/storm-jms/pom.xml
@@ -94,7 +94,7 @@
maven-checkstyle-plugin
- 941
+ 273
diff --git a/external/storm-kafka-client/pom.xml b/external/storm-kafka-client/pom.xml
index cac0018f27b..7fb219ac6f6 100644
--- a/external/storm-kafka-client/pom.xml
+++ b/external/storm-kafka-client/pom.xml
@@ -152,7 +152,7 @@
maven-checkstyle-plugin
- 2439
+ 338
diff --git a/external/storm-kafka-monitor/pom.xml b/external/storm-kafka-monitor/pom.xml
index edd612b39ff..089a4c601d9 100644
--- a/external/storm-kafka-monitor/pom.xml
+++ b/external/storm-kafka-monitor/pom.xml
@@ -149,7 +149,7 @@
maven-checkstyle-plugin
- 735
+ 178
diff --git a/external/storm-kafka/pom.xml b/external/storm-kafka/pom.xml
index f6d1e0de95b..14fd6093afa 100644
--- a/external/storm-kafka/pom.xml
+++ b/external/storm-kafka/pom.xml
@@ -57,7 +57,7 @@
maven-checkstyle-plugin
- 2727
+ 557
diff --git a/external/storm-kinesis/pom.xml b/external/storm-kinesis/pom.xml
index b9826cd408b..0f6f16cc2d4 100644
--- a/external/storm-kinesis/pom.xml
+++ b/external/storm-kinesis/pom.xml
@@ -71,7 +71,7 @@
maven-checkstyle-plugin
- 1118
+ 185
diff --git a/external/storm-metrics/pom.xml b/external/storm-metrics/pom.xml
index 1168b18cf11..c1d49ac7a2c 100644
--- a/external/storm-metrics/pom.xml
+++ b/external/storm-metrics/pom.xml
@@ -106,7 +106,7 @@
maven-checkstyle-plugin
- 87
+ 32
diff --git a/external/storm-mongodb/pom.xml b/external/storm-mongodb/pom.xml
index 9095320eac7..977c779f73c 100644
--- a/external/storm-mongodb/pom.xml
+++ b/external/storm-mongodb/pom.xml
@@ -79,7 +79,7 @@
maven-checkstyle-plugin
- 665
+ 96
diff --git a/external/storm-mqtt/pom.xml b/external/storm-mqtt/pom.xml
index c8dfd7fb5f4..4546fcb0cca 100644
--- a/external/storm-mqtt/pom.xml
+++ b/external/storm-mqtt/pom.xml
@@ -130,7 +130,7 @@
maven-checkstyle-plugin
- 808
+ 158
diff --git a/external/storm-opentsdb/pom.xml b/external/storm-opentsdb/pom.xml
index 2af8a6d3bbc..1613095598f 100644
--- a/external/storm-opentsdb/pom.xml
+++ b/external/storm-opentsdb/pom.xml
@@ -102,7 +102,7 @@
maven-checkstyle-plugin
- 541
+ 94
diff --git a/external/storm-pmml/pom.xml b/external/storm-pmml/pom.xml
index ee550d0d553..839cb3c86c3 100644
--- a/external/storm-pmml/pom.xml
+++ b/external/storm-pmml/pom.xml
@@ -85,7 +85,7 @@
- 373
+ 65
diff --git a/external/storm-redis/pom.xml b/external/storm-redis/pom.xml
index 0cfe8ad15b9..b7c946f7182 100644
--- a/external/storm-redis/pom.xml
+++ b/external/storm-redis/pom.xml
@@ -95,7 +95,7 @@
maven-checkstyle-plugin
- 2041
+ 598
diff --git a/external/storm-rocketmq/pom.xml b/external/storm-rocketmq/pom.xml
index 9a90e927c03..4e3d729e6b5 100644
--- a/external/storm-rocketmq/pom.xml
+++ b/external/storm-rocketmq/pom.xml
@@ -75,7 +75,7 @@
maven-checkstyle-plugin
- 705
+ 100
diff --git a/external/storm-solr/pom.xml b/external/storm-solr/pom.xml
index 9e67027850b..fc43d8c1f9a 100644
--- a/external/storm-solr/pom.xml
+++ b/external/storm-solr/pom.xml
@@ -109,7 +109,7 @@
maven-checkstyle-plugin
- 781
+ 108
diff --git a/flux/flux-core/pom.xml b/flux/flux-core/pom.xml
index c25d04f858a..7df517b8291 100644
--- a/flux/flux-core/pom.xml
+++ b/flux/flux-core/pom.xml
@@ -112,7 +112,7 @@
maven-checkstyle-plugin
- 1568
+ 285
diff --git a/flux/flux-wrappers/pom.xml b/flux/flux-wrappers/pom.xml
index a9987b43662..103fb037860 100644
--- a/flux/flux-wrappers/pom.xml
+++ b/flux/flux-wrappers/pom.xml
@@ -55,7 +55,7 @@
maven-checkstyle-plugin
- 479
+ 38
diff --git a/pom.xml b/pom.xml
index 10dd4b945d9..bdcc716d634 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1092,14 +1092,23 @@
org.apache.maven.plugins
maven-checkstyle-plugin
2.17
+
+
+ com.puppycrawl.tools
+ checkstyle
+
+ 7.7
+
+
validate
validate
- google_checks.xml
+ storm-buildtools/storm_checkstyle.xml
UTF-8
-
+ true
false
warning
diff --git a/sql/storm-sql-core/pom.xml b/sql/storm-sql-core/pom.xml
index 1136319d4c9..e0ea09952ca 100644
--- a/sql/storm-sql-core/pom.xml
+++ b/sql/storm-sql-core/pom.xml
@@ -170,7 +170,7 @@
maven-checkstyle-plugin
- 1217
+ 1283
diff --git a/sql/storm-sql-external/storm-sql-hdfs/pom.xml b/sql/storm-sql-external/storm-sql-hdfs/pom.xml
index b06fe1fb4c6..eedd789f079 100644
--- a/sql/storm-sql-external/storm-sql-hdfs/pom.xml
+++ b/sql/storm-sql-external/storm-sql-hdfs/pom.xml
@@ -106,7 +106,7 @@
maven-checkstyle-plugin
- 43
+ 54
diff --git a/sql/storm-sql-external/storm-sql-kafka/pom.xml b/sql/storm-sql-external/storm-sql-kafka/pom.xml
index fc6b2d30a26..b723329f337 100644
--- a/sql/storm-sql-external/storm-sql-kafka/pom.xml
+++ b/sql/storm-sql-external/storm-sql-kafka/pom.xml
@@ -95,7 +95,7 @@
maven-checkstyle-plugin
- 61
+ 96
diff --git a/sql/storm-sql-external/storm-sql-mongodb/pom.xml b/sql/storm-sql-external/storm-sql-mongodb/pom.xml
index 0944d4d294e..87dc564a0f1 100644
--- a/sql/storm-sql-external/storm-sql-mongodb/pom.xml
+++ b/sql/storm-sql-external/storm-sql-mongodb/pom.xml
@@ -86,7 +86,7 @@
maven-checkstyle-plugin
- 47
+ 54
diff --git a/sql/storm-sql-external/storm-sql-redis/pom.xml b/sql/storm-sql-external/storm-sql-redis/pom.xml
index 7d0cc06f4fe..c2fb1d1adf5 100644
--- a/sql/storm-sql-external/storm-sql-redis/pom.xml
+++ b/sql/storm-sql-external/storm-sql-redis/pom.xml
@@ -78,7 +78,7 @@
maven-checkstyle-plugin
- 92
+ 129
diff --git a/sql/storm-sql-runtime/pom.xml b/sql/storm-sql-runtime/pom.xml
index 2f57d7c020f..511c792c184 100644
--- a/sql/storm-sql-runtime/pom.xml
+++ b/sql/storm-sql-runtime/pom.xml
@@ -136,7 +136,7 @@
maven-checkstyle-plugin
- 639
+ 485
diff --git a/storm-buildtools/maven-shade-clojure-transformer/pom.xml b/storm-buildtools/maven-shade-clojure-transformer/pom.xml
index b2e2575ff91..cdb6fa87d9b 100644
--- a/storm-buildtools/maven-shade-clojure-transformer/pom.xml
+++ b/storm-buildtools/maven-shade-clojure-transformer/pom.xml
@@ -42,7 +42,7 @@
maven-checkstyle-plugin
- 44
+ 16
diff --git a/storm-buildtools/storm-maven-plugins/pom.xml b/storm-buildtools/storm-maven-plugins/pom.xml
index 0b9eb1c5e7b..3f0a27d437c 100644
--- a/storm-buildtools/storm-maven-plugins/pom.xml
+++ b/storm-buildtools/storm-maven-plugins/pom.xml
@@ -81,7 +81,7 @@
maven-checkstyle-plugin
- 78
+ 269
diff --git a/storm-buildtools/storm_checkstyle.xml b/storm-buildtools/storm_checkstyle.xml
new file mode 100644
index 00000000000..248e3ce3493
--- /dev/null
+++ b/storm-buildtools/storm_checkstyle.xml
@@ -0,0 +1,253 @@
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
diff --git a/storm-client-misc/pom.xml b/storm-client-misc/pom.xml
index 5543426f593..91615695b42 100644
--- a/storm-client-misc/pom.xml
+++ b/storm-client-misc/pom.xml
@@ -54,7 +54,7 @@
maven-checkstyle-plugin
- 137
+ 39
diff --git a/storm-client/pom.xml b/storm-client/pom.xml
index 706cc169828..30d7685d6c1 100644
--- a/storm-client/pom.xml
+++ b/storm-client/pom.xml
@@ -251,7 +251,8 @@
maven-checkstyle-plugin
- 92181
+ **/generated/**
+ 10785
diff --git a/storm-clojure/pom.xml b/storm-clojure/pom.xml
index f2eed1668c0..d436f19ec5b 100644
--- a/storm-clojure/pom.xml
+++ b/storm-clojure/pom.xml
@@ -112,7 +112,7 @@
maven-checkstyle-plugin
- 796
+ 173
diff --git a/storm-core/pom.xml b/storm-core/pom.xml
index 4ff298ebc8b..ad4972e141d 100644
--- a/storm-core/pom.xml
+++ b/storm-core/pom.xml
@@ -468,7 +468,7 @@
maven-checkstyle-plugin
- 1950
+ 254
diff --git a/storm-rename-hack/pom.xml b/storm-rename-hack/pom.xml
index 5d9b712c0ad..d602872daeb 100644
--- a/storm-rename-hack/pom.xml
+++ b/storm-rename-hack/pom.xml
@@ -123,7 +123,7 @@
maven-checkstyle-plugin
- 565
+ 408
diff --git a/storm-server/pom.xml b/storm-server/pom.xml
index 8872171f6d1..311b58f5159 100644
--- a/storm-server/pom.xml
+++ b/storm-server/pom.xml
@@ -131,7 +131,7 @@
maven-checkstyle-plugin
- 14979
+ 3584
diff --git a/storm-server/src/main/java/org/apache/storm/logging/filters/AccessLoggingFilter.java b/storm-server/src/main/java/org/apache/storm/logging/filters/AccessLoggingFilter.java
index 46d19215977..864b053c4ee 100644
--- a/storm-server/src/main/java/org/apache/storm/logging/filters/AccessLoggingFilter.java
+++ b/storm-server/src/main/java/org/apache/storm/logging/filters/AccessLoggingFilter.java
@@ -15,6 +15,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
+
package org.apache.storm.logging.filters;
import java.io.IOException;
import javax.servlet.Filter;
diff --git a/storm-submit-tools/pom.xml b/storm-submit-tools/pom.xml
index 9be5a52f47f..1cdf04cff49 100644
--- a/storm-submit-tools/pom.xml
+++ b/storm-submit-tools/pom.xml
@@ -189,7 +189,7 @@
maven-checkstyle-plugin
- 269
+ 38
diff --git a/storm-webapp/pom.xml b/storm-webapp/pom.xml
index 52e1eb4de98..4cdc1ae6a72 100644
--- a/storm-webapp/pom.xml
+++ b/storm-webapp/pom.xml
@@ -118,7 +118,7 @@
maven-checkstyle-plugin
- 290
+ 41