From 280ecab0e6a7a7828fe2425b67cc68ba6795f3d3 Mon Sep 17 00:00:00 2001 From: Ville Brofeldt <33317356+villebro@users.noreply.github.com> Date: Thu, 7 Apr 2022 14:30:36 +0300 Subject: [PATCH] chore: remove redundant adodbapi warning (#19557) (cherry picked from commit 0d331f5bd81f25bc92a20da6ed8d99f0c393efb2) --- superset/db_engine_specs/__init__.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/superset/db_engine_specs/__init__.py b/superset/db_engine_specs/__init__.py index 9eeb87acfe0cd..4474f2a748216 100644 --- a/superset/db_engine_specs/__init__.py +++ b/superset/db_engine_specs/__init__.py @@ -116,6 +116,9 @@ def get_available_engine_specs() -> Dict[Type[BaseEngineSpec], Set[str]]: hasattr(attribute, "dialect") and inspect.isclass(attribute.dialect) and issubclass(attribute.dialect, DefaultDialect) + # adodbapi dialect is removed in SQLA 1.4 and doesn't implement the + # `dbapi` method, hence needs to be ignored to avoid logging a warning + and attribute.dialect.driver != "adodbapi" ): try: attribute.dialect.dbapi()