diff --git a/superset-frontend/src/addSlice/AddSliceContainer.tsx b/superset-frontend/src/addSlice/AddSliceContainer.tsx index 9507327776868..26a910f907f36 100644 --- a/superset-frontend/src/addSlice/AddSliceContainer.tsx +++ b/superset-frontend/src/addSlice/AddSliceContainer.tsx @@ -23,7 +23,7 @@ import { styled, t, SupersetClient, JsonResponse } from '@superset-ui/core'; import { getUrlParam } from 'src/utils/urlUtils'; import { URL_PARAMS } from 'src/constants'; import { isNullish } from 'src/utils/common'; -import { withRouter, RouteComponentProps } from 'react-router-dom'; +import { Link, withRouter, RouteComponentProps } from 'react-router-dom'; import Button from 'src/components/Button'; import { AsyncSelect, Steps } from 'src/components'; import { Tooltip } from 'src/components/Tooltip'; @@ -32,7 +32,6 @@ import withToasts from 'src/components/MessageToasts/withToasts'; import VizTypeGallery, { MAX_ADVISABLE_VIZ_GALLERY_WIDTH, } from 'src/explore/components/controls/VizTypeControl/VizTypeGallery'; -import _ from 'lodash'; import { findPermission } from 'src/utils/findPermission'; import { UserWithPermissionsAndRoles } from 'src/types/bootstrapTypes'; @@ -329,18 +328,18 @@ export class AddSliceContainer extends React.PureComponent< const isButtonDisabled = this.isBtnDisabled(); const datasetHelpText = this.state.canCreateDataset ? ( - {t('Add a dataset')} - + {` ${t('or')} `} {`${t('view instructions')} `} diff --git a/superset-frontend/src/views/CRUD/data/dataset/AddDatasetModal.tsx b/superset-frontend/src/views/CRUD/data/dataset/AddDatasetModal.tsx index 02cc5d12ad893..edc6d749501a8 100644 --- a/superset-frontend/src/views/CRUD/data/dataset/AddDatasetModal.tsx +++ b/superset-frontend/src/views/CRUD/data/dataset/AddDatasetModal.tsx @@ -17,6 +17,7 @@ * under the License. */ import React, { FunctionComponent, useState, useEffect } from 'react'; +import { useHistory } from 'react-router-dom'; import { styled, t } from '@superset-ui/core'; import { useSingleViewResource } from 'src/views/CRUD/hooks'; import Modal from 'src/components/Modal'; @@ -54,6 +55,7 @@ const DatasetModal: FunctionComponent = ({ onHide, show, }) => { + const history = useHistory(); const [currentDatabase, setCurrentDatabase] = useState< DatabaseObject | undefined >(); @@ -100,9 +102,13 @@ const DatasetModal: FunctionComponent = ({ setDisableSave(true); }; - const hide = () => { - setItem(LocalStorageKeys.db, null); + const cleanup = () => { clearModal(); + setItem(LocalStorageKeys.db, null); + }; + + const hide = () => { + cleanup(); onHide(); }; @@ -122,8 +128,8 @@ const DatasetModal: FunctionComponent = ({ if (onDatasetAdd) { onDatasetAdd({ id: response.id, ...response }); } - window.location.href = `/chart/add?dataset=${currentTableName}`; - hide(); + history.push(`/chart/add?dataset=${currentTableName}`); + cleanup(); }); };