From 5e0603f957da9d45d291aab28853c60941e96a1a Mon Sep 17 00:00:00 2001 From: John Bodley <4567245+john-bodley@users.noreply.github.com> Date: Sun, 4 Oct 2020 09:16:29 -0700 Subject: [PATCH] chore: Remove obsolete creating missing metric permissions (#11143) --- superset/security/manager.py | 6 ------ 1 file changed, 6 deletions(-) diff --git a/superset/security/manager.py b/superset/security/manager.py index df2b3e0f8ec48..17db91e9ac910 100644 --- a/superset/security/manager.py +++ b/superset/security/manager.py @@ -551,7 +551,6 @@ def create_missing_perms(self) -> None: Creates missing FAB permissions for datasources, schemas and metrics. """ - from superset.connectors.base.models import BaseMetric from superset.models import core as models logger.info("Fetching a set of all perms to lookup which ones are missing") @@ -576,11 +575,6 @@ def merge_pv(view_menu: str, perm: str) -> None: for database in databases: merge_pv("database_access", database.perm) - logger.info("Creating missing metrics permissions") - metrics: List[BaseMetric] = [] - for datasource_class in ConnectorRegistry.sources.values(): - metrics += list(self.get_session.query(datasource_class.metric_class).all()) - def clean_perms(self) -> None: """ Clean up the FAB faulty permissions.