diff --git a/.github/workflows/embedded-sdk-release.yml b/.github/workflows/embedded-sdk-release.yml index b0c75343824d3..3ca29013e6b6d 100644 --- a/.github/workflows/embedded-sdk-release.yml +++ b/.github/workflows/embedded-sdk-release.yml @@ -31,7 +31,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: "18" + node-version: "20" registry-url: 'https://registry.npmjs.org' - run: npm ci - run: npm run ci:release diff --git a/.github/workflows/embedded-sdk-test.yml b/.github/workflows/embedded-sdk-test.yml index 50058d0af75f9..62add4b25745e 100644 --- a/.github/workflows/embedded-sdk-test.yml +++ b/.github/workflows/embedded-sdk-test.yml @@ -21,7 +21,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: "18" + node-version: "20" registry-url: 'https://registry.npmjs.org' - run: npm ci - run: npm test diff --git a/.github/workflows/github-action-validator.yml b/.github/workflows/github-action-validator.yml index 5acc5e0880e1d..adc8397817ab1 100644 --- a/.github/workflows/github-action-validator.yml +++ b/.github/workflows/github-action-validator.yml @@ -19,7 +19,7 @@ jobs: - name: Set up Node.js uses: actions/setup-node@v4 with: - node-version: '18' + node-version: '20' - name: Install Dependencies run: npm install -g @action-validator/core @action-validator/cli --save-dev diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 4435054a5c7a2..0fb4afa4fc525 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -29,7 +29,7 @@ jobs: strategy: matrix: - node-version: [18] + node-version: [20] steps: - uses: actions/checkout@v4 diff --git a/.github/workflows/superset-applitool-cypress.yml b/.github/workflows/superset-applitool-cypress.yml index 72fd1a7343218..627c729a22492 100644 --- a/.github/workflows/superset-applitool-cypress.yml +++ b/.github/workflows/superset-applitool-cypress.yml @@ -26,7 +26,7 @@ jobs: fail-fast: false matrix: browser: ["chrome"] - node: [18] + node: [20] env: SUPERSET_ENV: development SUPERSET_CONFIG: tests.integration_tests.superset_test_config diff --git a/.github/workflows/superset-applitools-storybook.yml b/.github/workflows/superset-applitools-storybook.yml index 5382120bc163f..583bfbea5b54a 100644 --- a/.github/workflows/superset-applitools-storybook.yml +++ b/.github/workflows/superset-applitools-storybook.yml @@ -30,7 +30,7 @@ jobs: runs-on: ubuntu-22.04 strategy: matrix: - node: [18] + node: [20] steps: - name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )" uses: actions/checkout@v4 diff --git a/.github/workflows/superset-e2e.yml b/.github/workflows/superset-e2e.yml index 092864246240b..2c3abd4be30d9 100644 --- a/.github/workflows/superset-e2e.yml +++ b/.github/workflows/superset-e2e.yml @@ -107,7 +107,7 @@ jobs: if: steps.check.outputs.python || steps.check.outputs.frontend uses: actions/setup-node@v4 with: - node-version: "18" + node-version: "20" - name: Install npm dependencies if: steps.check.outputs.python || steps.check.outputs.frontend uses: ./.github/actions/cached-dependencies diff --git a/.github/workflows/superset-frontend.yml b/.github/workflows/superset-frontend.yml index eb405963611a1..c603f01812cf5 100644 --- a/.github/workflows/superset-frontend.yml +++ b/.github/workflows/superset-frontend.yml @@ -33,7 +33,7 @@ jobs: if: steps.check.outputs.frontend uses: actions/setup-node@v4 with: - node-version: "18" + node-version: "20" - name: Install dependencies if: steps.check.outputs.frontend uses: ./.github/actions/cached-dependencies diff --git a/.github/workflows/tech-debt.yml b/.github/workflows/tech-debt.yml index f17e220a402b4..c87d0dd1af4c3 100644 --- a/.github/workflows/tech-debt.yml +++ b/.github/workflows/tech-debt.yml @@ -32,7 +32,7 @@ jobs: - name: Set up Node.js uses: actions/setup-node@v4 with: - node-version: '18' + node-version: '20' - name: Install Dependencies run: npm install diff --git a/Dockerfile b/Dockerfile index e83c81471d91c..cd859490d32b9 100644 --- a/Dockerfile +++ b/Dockerfile @@ -22,7 +22,7 @@ ARG PY_VER=3.10-slim-bookworm # if BUILDPLATFORM is null, set it to 'amd64' (or leave as is otherwise). ARG BUILDPLATFORM=${BUILDPLATFORM:-amd64} -FROM --platform=${BUILDPLATFORM} node:18-bullseye-slim AS superset-node +FROM --platform=${BUILDPLATFORM} node:20-bullseye-slim AS superset-node ARG NPM_BUILD_CMD="build" diff --git a/docker-compose.yml b/docker-compose.yml index aa8d940a8cdef..d0121fa874622 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -147,7 +147,7 @@ services: disable: true superset-node: - image: node:18 + image: node:20 environment: # set this to false if you have perf issues running the npm i; npm run dev in-docker # if you do so, you have to run this manually on the host, which should perform better! diff --git a/docs/.nvmrc b/docs/.nvmrc index a81debaeef4eb..80a9956e1e504 100644 --- a/docs/.nvmrc +++ b/docs/.nvmrc @@ -1 +1 @@ -v20.12.2 +v20.16.0 diff --git a/docs/docs/contributing/development.mdx b/docs/docs/contributing/development.mdx index f674e443786d2..155c6a7b57b67 100644 --- a/docs/docs/contributing/development.mdx +++ b/docs/docs/contributing/development.mdx @@ -268,7 +268,7 @@ Frontend assets (TypeScript, JavaScript, CSS, and images) must be compiled in or First, be sure you are using the following versions of Node.js and npm: -- `Node.js`: Version 18 +- `Node.js`: Version 20 - `npm`: Version 10 We recommend using [nvm](https://github.com/nvm-sh/nvm) to manage your node environment: diff --git a/superset-frontend/.nvmrc b/superset-frontend/.nvmrc index ef33d6510196d..80a9956e1e504 100644 --- a/superset-frontend/.nvmrc +++ b/superset-frontend/.nvmrc @@ -1 +1 @@ -v18.20.1 +v20.16.0 diff --git a/superset-frontend/package-lock.json b/superset-frontend/package-lock.json index b83e5109d58d2..8e598c131b621 100644 --- a/superset-frontend/package-lock.json +++ b/superset-frontend/package-lock.json @@ -292,8 +292,8 @@ "xdm": "^3.4.0" }, "engines": { - "node": "^18.19.1", - "npm": "^10.2.4" + "node": "^20.16.0", + "npm": "^10.8.1" } }, "node_modules/@aashutoshrathi/word-wrap": { diff --git a/superset-frontend/package.json b/superset-frontend/package.json index 220a84dbfa3bd..91c43e7f785cb 100644 --- a/superset-frontend/package.json +++ b/superset-frontend/package.json @@ -358,8 +358,8 @@ "xdm": "^3.4.0" }, "engines": { - "node": "^18.19.1", - "npm": "^10.2.4" + "node": "^20.16.0", + "npm": "^10.8.1" }, "overrides": { "d3-color": "^3.1.0", diff --git a/superset-websocket/.nvmrc b/superset-websocket/.nvmrc index ef33d6510196d..80a9956e1e504 100644 --- a/superset-websocket/.nvmrc +++ b/superset-websocket/.nvmrc @@ -1 +1 @@ -v18.20.1 +v20.16.0 diff --git a/superset-websocket/utils/client-ws-app/.nvmrc b/superset-websocket/utils/client-ws-app/.nvmrc index ef33d6510196d..80a9956e1e504 100644 --- a/superset-websocket/utils/client-ws-app/.nvmrc +++ b/superset-websocket/utils/client-ws-app/.nvmrc @@ -1 +1 @@ -v18.20.1 +v20.16.0