From e7b27f0778775d201de1ac8829b4ffafa66be7b8 Mon Sep 17 00:00:00 2001 From: John Bodley <4567245+john-bodley@users.noreply.github.com> Date: Mon, 12 Jun 2023 11:43:28 -0700 Subject: [PATCH] fix: Ensure "Import Dashboard" menu item adheres to PVM (#24143) --- superset/initialization/__init__.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/superset/initialization/__init__.py b/superset/initialization/__init__.py index fdf5492201830..3d7d9817f787e 100644 --- a/superset/initialization/__init__.py +++ b/superset/initialization/__init__.py @@ -116,6 +116,7 @@ def init_views(self) -> None: # the global Flask app # # pylint: disable=import-outside-toplevel,too-many-locals,too-many-statements + from superset import security_manager from superset.advanced_data_type.api import AdvancedDataTypeRestApi from superset.annotation_layers.annotations.api import AnnotationRestApi from superset.annotation_layers.api import AnnotationLayerRestApi @@ -333,10 +334,12 @@ def init_views(self) -> None: category="Manage", category_label=__("Manage"), category_icon="fa-wrench", - cond=lambda: not feature_flag_manager.is_feature_enabled( - "VERSIONED_EXPORT" + cond=lambda: ( + security_manager.can_access("can_import_dashboards", "Superset") + and not feature_flag_manager.is_feature_enabled("VERSIONED_EXPORT") ), ) + appbuilder.add_link( "SQL Editor", label=__("SQL Lab"),