created useEffect so that title properly changes in modal

apache · Jan 12, 2022 · ed14a6f · ed14a6f
1 parent b621a25
commit ed14a6f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/superset-frontend/src/SqlLab/components/SaveQuery/index.tsx b/superset-frontend/src/SqlLab/components/SaveQuery/index.tsx
@@ -16,7 +16,7 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import React, { useState } from 'react';
+import React, { useState, useEffect } from 'react';
 import { Row, Col, Input, TextArea } from 'src/common/components';
 import { t, styled } from '@superset-ui/core';
 import Button from 'src/components/Button';
@@ -90,6 +90,11 @@ export default function SaveQuery({
     description,
   });
 
+  useEffect(() => {
+    if (!isSaved) {
+      setLabel(defaultLabel);
+    }
+  }, [defaultLabel]);
   const close = () => {
     setShowSave(false);
   };

diff --git a/superset-frontend/src/SqlLab/types.ts b/superset-frontend/src/SqlLab/types.ts
@@ -69,6 +69,7 @@ export type Query = {
   queryLimit: number;
   limitingFactor: string;
 };
+
 export interface QueryEditor {
   dbId?: number;
   title: string;