Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui] fix /caravel/theme #897

Closed
8 tasks done
ascott opened this issue Aug 8, 2016 · 4 comments
Closed
8 tasks done

[ui] fix /caravel/theme #897

ascott opened this issue Aug 8, 2016 · 4 comments
Assignees
@ascott
Labels
airbnb Airbnb related
Milestone
Edinburgh Sprint ...

Comments

@ascott
Copy link

ascott commented Aug 8, 2016 •
edited
Loading

it is very broken after last ui update.

  • make buttons look more clearly like buttons (background-color? border? box-shadow?)
  • make links look more like links (color? underline?)
  • roll back to previous alert colors? (I tweaked them recently and liked them better than what there now)
  • Slice title in explore view should maybe wrap somehow or the right controls pushed down...
  • make tabs look like tabs
  • controls' info-bubbles with tooltip in the explore view are gone
  • Loading spinner doesn't show in explore view
  • Explore view fails hard when following a table link (when no slices have been defined yet)
@ascott ascott added the ui label Aug 8, 2016
@ascott ascott added this to the Edinburgh Sprint 2016-08-19 milestone Aug 8, 2016
@ascott ascott self-assigned this Aug 8, 2016
@mistercrunch
Copy link
Member

mistercrunch commented Aug 8, 2016 •
edited
Loading

Still a very net positive set of changes!

A few notes:

  • make buttons look more clearly like buttons (background-color? border? box-shadow?)
  • make links look more like links (color? underline?)
  • roll back to previous alert colors? (I tweaked them recently and liked them better than what there now)
  • Slice title in explore view should maybe wrap somehow or the right controls pushed down...
  • make tabs look like tabs

@mistercrunch mistercrunch added the airbnb Airbnb related label Aug 8, 2016
@mistercrunch
Copy link
Member

Also just noticed that the controls' info-bubbles with tooltip in the explore view are gone....

@mistercrunch
Copy link
Member

Loading spinner doesn't show in explore view

@mistercrunch
Copy link
Member

Explore view fails hard when following a table link (when no slices have been defined yet)

@ascott ascott mentioned this issue Aug 17, 2016
Merged
@ascott ascott closed this as completed Aug 17, 2016
@laxmanraparthi laxmanraparthi mentioned this issue Jul 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ascott ascott

Labels
airbnb Airbnb related
Projects
None yet
Milestone
Edinburgh Sprint 2016-08-19
Development

No branches or pull requests
2 participants
@ascott @mistercrunch