Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in Histogram #982

Closed
shkr opened this issue Aug 18, 2016 · 1 comment · Fixed by #987
Closed

Error in Histogram #982

shkr opened this issue Aug 18, 2016 · 1 comment · Fixed by #987
Labels
!deprecated-label:bug Deprecated label - Use #bug instead

Comments

@shkr
Copy link
Contributor

shkr commented Aug 18, 2016

This error is thrown by histogram.js.

explore.entry.js:61377 Uncaught TypeError: Cannot read property 'category21' of undefined

Relevant code in histogram.js

const px = window.px || require('../javascripts/modules/caravel.js')
...





....

function(d) { return px.color.category21(d.length); })
@xrmx
Copy link
Contributor

xrmx commented Aug 19, 2016

@shkr care to cook a patch? It should be something like this e243a14#diff-dfea42de2be6be52c71f766780861c3cL3

@xrmx xrmx added the !deprecated-label:bug Deprecated label - Use #bug instead label Aug 19, 2016
@mistercrunch mistercrunch mentioned this issue Aug 19, 2016
Merged
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 17, 2021
@villebro @zhaoyongjie
feat(core): copy feature flags from main repo (apache#982)
de84c04
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 24, 2021
@villebro @zhaoyongjie
feat(core): copy feature flags from main repo (apache#982)
4615dbc
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 25, 2021
@villebro @zhaoyongjie
feat(core): copy feature flags from main repo (apache#982)
2447230
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 26, 2021
@villebro @zhaoyongjie
feat(core): copy feature flags from main repo (apache#982)
0f8df43
@laxmanraparthi laxmanraparthi mentioned this issue Jul 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
!deprecated-label:bug Deprecated label - Use #bug instead
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[bugfix] fixing && linting the histogram viz mistercrunch/superset
2 participants
@xrmx @shkr