fix: Disabling timezone of dataframe before passing Prophet #11107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While running forecasting with Druid. Prophet throws the following exception. This PR removes the timezone info. ValueError: Column ds has timezone specified, which is not supported. Remove timezone apache#11106 @villebro
|
Thanks @kkalyan , I'll review shortly. I assume this is Druid SQL? |
|
@villebro yes, its Druid SQL (version: 0.19.0). After patching this one line change, forecasting worked fine. |
villebro
requested changes
Sep 30, 2020
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
|
@kkalyan the cypress test seems flaky, gonna restart it until it starts working. |
villebro
approved these changes
Sep 30, 2020
dpgaspar
pushed a commit
that referenced
this pull request
Oct 1, 2020
* fix: Disabling timezone of dataframe before passing Prophet While running forecasting with Druid. Prophet throws the following exception. This PR removes the timezone info. ValueError: Column ds has timezone specified, which is not supported. Remove timezone #11106 @villebro * Update pandas_postprocessing.py * Update superset/utils/pandas_postprocessing.py Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
…1107) * fix: Disabling timezone of dataframe before passing Prophet While running forecasting with Druid. Prophet throws the following exception. This PR removes the timezone info. ValueError: Column ds has timezone specified, which is not supported. Remove timezone apache#11106 @villebro * Update pandas_postprocessing.py * Update superset/utils/pandas_postprocessing.py Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
This was referenced Nov 26, 2023
This was referenced Dec 14, 2023
This was referenced Dec 20, 2023
mistercrunch
added
🏷️ bot
This was referenced May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running forecasting with Druid. Prophet throws the following exception. This PR removes the timezone info.
ValueError: Column ds has timezone specified, which is not supported. Remove timezone
#11106
@villebro
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TEST PLAN
ADDITIONAL INFORMATION