-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Migrate react-select to Antd Select in Metrics and Filters popovers #12042
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12042 +/- ##
==========================================
- Coverage 67.71% 63.90% -3.81%
==========================================
Files 952 952
Lines 46686 46707 +21
Branches 4577 4586 +9
==========================================
- Hits 31615 29850 -1765
- Misses 14958 16673 +1715
- Partials 113 184 +71
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
We only added that placeholder pretty recently. I would hate to have to see it go. cc @eschutho |
Hmm I see. I'll try to look for a workaround |
@kgabryje please progress to the next refactoring/restyling task in Explore first. we can revisit and bring the place holder back after the 18th. |
@kgabryje I think I found a way to use Emotion and the |
Thanks @rusackas, works like a charm! I needed to add some conditions when to display that labelText, because simply replacing placeholder with labelText did not work well in some cases, but other than that it seems ok! Would appreciate if you took another look |
0f70e40
to
de2007a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
SUMMARY
As a first part of #11916, I migrated react-select components in Filters and Metrics popovers to Antd. Next step will be refactoring MetricsControl and AdhocFiltersControl according to designs.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
As you can see on the before/after screenshot, there is 1 difference - in the bottom select input we no longer display placeholder that says how many options are left when there's at least 1 option selected. Antd doesn't support displaying such label.
Before:
After:
TEST PLAN
ADDITIONAL INFORMATION
CC: @junlincc @villebro @adam-stasiak