From 4748e6c0f76e78a4806cef615136555486f22ee8 Mon Sep 17 00:00:00 2001 From: Phillip Kelley-Dotson Date: Fri, 8 Oct 2021 16:32:16 -0700 Subject: [PATCH 01/11] inital fix --- .../FilterBar/CascadeFilters/CascadePopover/index.tsx | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx index 332fe8773e7c6..1391042f2b62d 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx @@ -76,7 +76,10 @@ const StyledPill = styled(Pill)` const ContentWrapper = styled.div` max-height: 700px; - overflow-y: auto; + .ant-select-dropdown { + // ensures dropdown positions correctly + top: 36px !important; + } `; const CascadePopover: React.FC = ({ From 530eab0b36cbe4c24f333bbd9b2e54b96dc7ab1b Mon Sep 17 00:00:00 2001 From: Phillip Kelley-Dotson Date: Mon, 11 Oct 2021 15:16:41 -0700 Subject: [PATCH 02/11] remove content wrapper --- .../CascadeFilters/CascadePopover/index.tsx | 26 ++++++------------- 1 file changed, 8 insertions(+), 18 deletions(-) diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx index 1391042f2b62d..ca380527dc4bc 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx @@ -74,14 +74,6 @@ const StyledPill = styled(Pill)` background: ${({ theme }) => theme.colors.grayscale.light1}; `; -const ContentWrapper = styled.div` - max-height: 700px; - .ant-select-dropdown { - // ensures dropdown positions correctly - top: 36px !important; - } -`; - const CascadePopover: React.FC = ({ dataMaskSelected, filter, @@ -181,16 +173,14 @@ const CascadePopover: React.FC = ({ ); const content = ( - - - + ); return ( From 8c3b0c1e9f8b9d4f2be7f1521d17ebdfaa8a9e56 Mon Sep 17 00:00:00 2001 From: Phillip Kelley-Dotson Date: Wed, 13 Oct 2021 17:02:26 -0700 Subject: [PATCH 03/11] allow dropdown to overflow in long chart --- .../CascadeFilterControl/index.tsx | 4 ++- .../CascadeFilters/CascadePopover/index.tsx | 30 +++++++++++++------ .../FilterControls/FilterControl.tsx | 2 ++ .../FilterBar/FilterControls/FilterValue.tsx | 2 ++ .../FilterBar/FilterControls/types.ts | 1 + .../components/Select/SelectFilterPlugin.tsx | 6 ++++ .../src/filters/components/Select/types.ts | 1 + 7 files changed, 36 insertions(+), 10 deletions(-) diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadeFilterControl/index.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadeFilterControl/index.tsx index 75d6497fab03a..7dc4336f01e81 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadeFilterControl/index.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadeFilterControl/index.tsx @@ -27,6 +27,7 @@ export interface CascadeFilterControlProps { dataMaskSelected?: DataMaskStateWithId; filter: CascadeFilter; directPathToChild?: string[]; + showOverflow?: boolean; onFilterSelectionChange: (filter: Filter, dataMask: DataMask) => void; } @@ -35,7 +36,6 @@ const StyledDiv = styled.div` width: 100%; flex-direction: column; align-items: center; - .ant-form-item { margin-bottom: ${({ theme }) => theme.gridUnit * 4}px; } @@ -52,6 +52,7 @@ const CascadeFilterControl: React.FC = ({ dataMaskSelected={dataMaskSelected} filter={filter} directPathToChild={directPathToChild} + showOverflow onFilterSelectionChange={onFilterSelectionChange} /> @@ -61,6 +62,7 @@ const CascadeFilterControl: React.FC = ({ dataMaskSelected={dataMaskSelected} filter={childFilter} directPathToChild={directPathToChild} + showOverflow onFilterSelectionChange={onFilterSelectionChange} /> ))} diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx index ca380527dc4bc..bd4f96d707cf7 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx @@ -74,6 +74,11 @@ const StyledPill = styled(Pill)` background: ${({ theme }) => theme.colors.grayscale.light1}; `; +const ContentStyles = styled.div` + max-height: 700px; + overflow: auto; +`; + const CascadePopover: React.FC = ({ dataMaskSelected, filter, @@ -173,14 +178,16 @@ const CascadePopover: React.FC = ({ ); const content = ( - + + + ); return ( @@ -192,7 +199,12 @@ const CascadePopover: React.FC = ({ onVisibleChange={onVisibleChange} placement="rightTop" id={filter.id} - overlayStyle={{ width: '400px' }} + overlayStyle={{ + width: '400px', + position: 'relative', + overflow: 'scroll', + }} + className="cascade-popover" >
{activeFilters.map(activeFilter => ( diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx index c952c1f250674..25647b82cf511 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx @@ -59,6 +59,7 @@ const FilterControl: React.FC = ({ onFilterSelectionChange, directPathToChild, inView, + showOverflow, }) => { const { name = '' } = filter; @@ -84,6 +85,7 @@ const FilterControl: React.FC = ({ = ({ directPathToChild, onFilterSelectionChange, inView = true, + showOverflow, }) => { const { id, targets, filterType, adhoc_filters, time_range } = filter; const metadata = getChartMetadataRegistry().get(filterType); @@ -225,6 +226,7 @@ const FilterValue: React.FC = ({ void; inView?: boolean; + showOverflow?: boolean; } diff --git a/superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx b/superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx index 6ae7cbeb225f2..c282d7ca16e0c 100644 --- a/superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx +++ b/superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx @@ -83,6 +83,7 @@ export default function PluginFilterSelect(props: PluginFilterSelectProps) { setFocusedFilter, unsetFocusedFilter, appSection, + showOverflow, } = props; const { enableEmptyFilter, @@ -278,6 +279,11 @@ export default function PluginFilterSelect(props: PluginFilterSelectProps) { // @ts-ignore value={filterState.value || []} disabled={isDisabled} + getPopupContainer={ + showOverflow + ? () => document.getElementsByClassName('cascade-popover') + : null + } showSearch={showSearch} mode={multiSelect ? 'multiple' : 'single'} placeholder={placeholderText} diff --git a/superset-frontend/src/filters/components/Select/types.ts b/superset-frontend/src/filters/components/Select/types.ts index 11e1d1d66fa05..e1aba653d092e 100644 --- a/superset-frontend/src/filters/components/Select/types.ts +++ b/superset-frontend/src/filters/components/Select/types.ts @@ -59,6 +59,7 @@ export type PluginFilterSelectProps = PluginFilterStylesProps & { formData: PluginFilterSelectQueryFormData; filterState: FilterState; isRefreshing: boolean; + showOverflow: boolean; } & PluginFilterHooks; export const DEFAULT_FORM_DATA: PluginFilterSelectCustomizeProps = { From 28ea985954022a0eb083ded3cd9ce2143e30914c Mon Sep 17 00:00:00 2001 From: Phillip Kelley-Dotson Date: Fri, 15 Oct 2021 10:57:35 -0700 Subject: [PATCH 04/11] only pass through filtercontrol --- .../FilterBar/CascadeFilters/CascadeFilterControl/index.tsx | 2 -- 1 file changed, 2 deletions(-) diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadeFilterControl/index.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadeFilterControl/index.tsx index 7dc4336f01e81..0f7c9c1f4d0b8 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadeFilterControl/index.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadeFilterControl/index.tsx @@ -27,7 +27,6 @@ export interface CascadeFilterControlProps { dataMaskSelected?: DataMaskStateWithId; filter: CascadeFilter; directPathToChild?: string[]; - showOverflow?: boolean; onFilterSelectionChange: (filter: Filter, dataMask: DataMask) => void; } @@ -62,7 +61,6 @@ const CascadeFilterControl: React.FC = ({ dataMaskSelected={dataMaskSelected} filter={childFilter} directPathToChild={directPathToChild} - showOverflow onFilterSelectionChange={onFilterSelectionChange} /> ))} From 8864ae12cc6615d2791c091f81d97fd2f5a748df Mon Sep 17 00:00:00 2001 From: Phillip Kelley-Dotson Date: Fri, 15 Oct 2021 14:00:22 -0700 Subject: [PATCH 05/11] change to auto --- .../FilterBar/CascadeFilters/CascadePopover/index.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx index bd4f96d707cf7..53f93202dd8e7 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx @@ -202,7 +202,7 @@ const CascadePopover: React.FC = ({ overlayStyle={{ width: '400px', position: 'relative', - overflow: 'scroll', + overflow: 'auto', }} className="cascade-popover" > From b1abda4eea16facffd2364841bebf6e8a49cd498 Mon Sep 17 00:00:00 2001 From: Phillip Kelley-Dotson Date: Mon, 18 Oct 2021 14:35:24 -0700 Subject: [PATCH 06/11] add ref and pass to child --- .../CascadeFilters/CascadeFilterControl/index.tsx | 5 ++++- .../FilterBar/CascadeFilters/CascadePopover/index.tsx | 6 ++++-- .../FilterBar/FilterControls/FilterControl.tsx | 2 ++ .../nativeFilters/FilterBar/FilterControls/FilterValue.tsx | 2 ++ .../nativeFilters/FilterBar/FilterControls/types.ts | 3 ++- .../src/filters/components/Select/SelectFilterPlugin.tsx | 7 ++----- 6 files changed, 16 insertions(+), 9 deletions(-) diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadeFilterControl/index.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadeFilterControl/index.tsx index 0f7c9c1f4d0b8..5b3085625de85 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadeFilterControl/index.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadeFilterControl/index.tsx @@ -16,7 +16,7 @@ * specific language governing permissions and limitations * under the License. */ -import React from 'react'; +import React, { RefObject } from 'react'; import { styled, DataMask } from '@superset-ui/core'; import FilterControl from 'src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl'; import { CascadeFilter } from 'src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/types'; @@ -28,6 +28,7 @@ export interface CascadeFilterControlProps { filter: CascadeFilter; directPathToChild?: string[]; onFilterSelectionChange: (filter: Filter, dataMask: DataMask) => void; + parentRef?: RefObject; } const StyledDiv = styled.div` @@ -45,12 +46,14 @@ const CascadeFilterControl: React.FC = ({ filter, directPathToChild, onFilterSelectionChange, + parentRef, }) => ( <> diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx index 53f93202dd8e7..748fa834d960e 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx @@ -16,7 +16,7 @@ * specific language governing permissions and limitations * under the License. */ -import React, { useCallback, useEffect, useMemo, useState } from 'react'; +import React, { useCallback, useEffect, useMemo, useState, useRef } from 'react'; import { styled, t, DataMask, css, SupersetTheme } from '@superset-ui/core'; import Popover from 'src/components/Popover'; import Icons from 'src/components/Icons'; @@ -90,6 +90,7 @@ const CascadePopover: React.FC = ({ }) => { const [currentPathToChild, setCurrentPathToChild] = useState(); const dataMask = dataMaskSelected[filter.id]; + const parent = useRef(); useEffect(() => { setCurrentPathToChild(directPathToChild); @@ -204,7 +205,8 @@ const CascadePopover: React.FC = ({ position: 'relative', overflow: 'auto', }} - className="cascade-popover" + // className="cascade-popover" + ref={parent} >
{activeFilters.map(activeFilter => ( diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx index 25647b82cf511..e6dfa79f86e60 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx @@ -60,6 +60,7 @@ const FilterControl: React.FC = ({ directPathToChild, inView, showOverflow, + parentRef, }) => { const { name = '' } = filter; @@ -89,6 +90,7 @@ const FilterControl: React.FC = ({ directPathToChild={directPathToChild} onFilterSelectionChange={onFilterSelectionChange} inView={inView} + parentRef={parentRef} /> diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterValue.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterValue.tsx index 8895dd2201668..5459cf08c28b8 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterValue.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterValue.tsx @@ -60,6 +60,7 @@ const FilterValue: React.FC = ({ onFilterSelectionChange, inView = true, showOverflow, + parentRef, }) => { const { id, targets, filterType, adhoc_filters, time_range } = filter; const metadata = getChartMetadataRegistry().get(filterType); @@ -228,6 +229,7 @@ const FilterValue: React.FC = ({ width="100%" showOverflow={showOverflow} formData={formData} + parentRef={parentRef} // For charts that don't have datasource we need workaround for empty placeholder queriesData={hasDataSource ? state : [{ data: [{}] }]} chartType={filterType} diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/types.ts b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/types.ts index 35f0ac444b887..52550c542f1dc 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/types.ts +++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/types.ts @@ -16,7 +16,7 @@ * specific language governing permissions and limitations * under the License. */ -import React from 'react'; +import React, { RefObject } from 'react'; import { DataMask } from '@superset-ui/core'; import { DataMaskStateWithId } from 'src/dataMask/types'; import { Filter } from '../../types'; @@ -31,4 +31,5 @@ export interface FilterProps { onFilterSelectionChange: (filter: Filter, dataMask: DataMask) => void; inView?: boolean; showOverflow?: boolean; + parentRef?: RefObject; } diff --git a/superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx b/superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx index c282d7ca16e0c..e6d412d0566e3 100644 --- a/superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx +++ b/superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx @@ -84,6 +84,7 @@ export default function PluginFilterSelect(props: PluginFilterSelectProps) { unsetFocusedFilter, appSection, showOverflow, + parentRef, } = props; const { enableEmptyFilter, @@ -279,11 +280,7 @@ export default function PluginFilterSelect(props: PluginFilterSelectProps) { // @ts-ignore value={filterState.value || []} disabled={isDisabled} - getPopupContainer={ - showOverflow - ? () => document.getElementsByClassName('cascade-popover') - : null - } + getPopupContainer={showOverflow ? () => parentRef : undefined} showSearch={showSearch} mode={multiSelect ? 'multiple' : 'single'} placeholder={placeholderText} From 5f863dae455c2332577ea94f0c01402cb56b37da Mon Sep 17 00:00:00 2001 From: Phillip Kelley-Dotson Date: Mon, 18 Oct 2021 21:42:41 -0700 Subject: [PATCH 07/11] fix bug --- .../FilterBar/CascadeFilters/CascadePopover/index.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx index 748fa834d960e..f1407151a3233 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx @@ -187,6 +187,7 @@ const CascadePopover: React.FC = ({ filter={filter} directPathToChild={visible ? currentPathToChild : undefined} onFilterSelectionChange={onFilterSelectionChange} + parentRef={parent} /> ); From dc671abd8a5b4eed98e95b1143590f958aa5917b Mon Sep 17 00:00:00 2001 From: Phillip Kelley-Dotson Date: Tue, 19 Oct 2021 11:37:50 -0700 Subject: [PATCH 08/11] fix lint --- .../FilterBar/CascadeFilters/CascadePopover/index.tsx | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx index 12dc3e657d6bc..fb64f1a220ded 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx @@ -16,7 +16,13 @@ * specific language governing permissions and limitations * under the License. */ -import React, { useCallback, useEffect, useMemo, useState, useRef } from 'react'; +import React, { + useCallback, + useEffect, + useMemo, + useState, + useRef, +} from 'react'; import { styled, t, DataMask, css, SupersetTheme } from '@superset-ui/core'; import Popover from 'src/components/Popover'; import Icons from 'src/components/Icons'; From 3d5f23bd70ed5e7d69a0dcd8b47ad414aaf14f73 Mon Sep 17 00:00:00 2001 From: Phillip Kelley-Dotson Date: Tue, 19 Oct 2021 12:33:28 -0700 Subject: [PATCH 09/11] add type --- superset-frontend/src/filters/components/Select/types.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/superset-frontend/src/filters/components/Select/types.ts b/superset-frontend/src/filters/components/Select/types.ts index e1aba653d092e..58124bbf94efe 100644 --- a/superset-frontend/src/filters/components/Select/types.ts +++ b/superset-frontend/src/filters/components/Select/types.ts @@ -60,6 +60,7 @@ export type PluginFilterSelectProps = PluginFilterStylesProps & { filterState: FilterState; isRefreshing: boolean; showOverflow: boolean; + parentRef?: RefObject; } & PluginFilterHooks; export const DEFAULT_FORM_DATA: PluginFilterSelectCustomizeProps = { From d92867d263da1602ff450deba941837b4d92513e Mon Sep 17 00:00:00 2001 From: Phillip Kelley-Dotson Date: Wed, 20 Oct 2021 09:14:17 -0700 Subject: [PATCH 10/11] remove code --- .../FilterBar/CascadeFilters/CascadePopover/index.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx index fb64f1a220ded..60cc4d60054bf 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx @@ -212,7 +212,6 @@ const CascadePopover: React.FC = ({ position: 'relative', overflow: 'auto', }} - // className="cascade-popover" ref={parent} >
From 8a152597e30b4acde38d45db5352d11e57cf3b9e Mon Sep 17 00:00:00 2001 From: Phillip Kelley-Dotson Date: Thu, 21 Oct 2021 08:49:34 -0700 Subject: [PATCH 11/11] add currrent param --- .../src/filters/components/Select/SelectFilterPlugin.tsx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx b/superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx index 080249254e0f0..37479523ed051 100644 --- a/superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx +++ b/superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx @@ -287,7 +287,9 @@ export default function PluginFilterSelect(props: PluginFilterSelectProps) { // @ts-ignore value={filterState.value || []} disabled={isDisabled} - getPopupContainer={showOverflow ? () => parentRef : undefined} + getPopupContainer={ + showOverflow ? () => parentRef?.current : undefined + } showSearch={showSearch} mode={multiSelect ? 'multiple' : 'single'} placeholder={placeholderText}