From b45e2e3863dc3d5bccea7f6b6b329237ae681519 Mon Sep 17 00:00:00 2001 From: Elizabeth Thompson Date: Wed, 1 Mar 2023 16:45:20 -0800 Subject: [PATCH 1/2] ignore ts warnings from older typescript versions --- superset-embedded-sdk/src/index.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/superset-embedded-sdk/src/index.ts b/superset-embedded-sdk/src/index.ts index 56a07e5544c1d..d2513422fa104 100644 --- a/superset-embedded-sdk/src/index.ts +++ b/superset-embedded-sdk/src/index.ts @@ -150,6 +150,7 @@ export async function embedDashboard({ }); iframe.src = `${supersetDomain}/embedded/${id}${dashboardConfig}${filterConfigUrlParams}`; + //@ts-ignore mountPoint.replaceChildren(iframe); log('placed the iframe') }); @@ -173,6 +174,7 @@ export async function embedDashboard({ function unmount() { log('unmounting'); + //@ts-ignore mountPoint.replaceChildren(); } From 4b5ec493bad415422789b0d93da4239cd548770c Mon Sep 17 00:00:00 2001 From: Elizabeth Thompson Date: Thu, 2 Mar 2023 11:20:14 -0800 Subject: [PATCH 2/2] bump the version for npm release script --- superset-embedded-sdk/package-lock.json | 4 ++-- superset-embedded-sdk/package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/superset-embedded-sdk/package-lock.json b/superset-embedded-sdk/package-lock.json index 826fb282c9e28..a8912e95dc8a0 100644 --- a/superset-embedded-sdk/package-lock.json +++ b/superset-embedded-sdk/package-lock.json @@ -1,12 +1,12 @@ { "name": "@superset-ui/embedded-sdk", - "version": "0.1.0-alpha.8", + "version": "0.1.0-alpha.9", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@superset-ui/embedded-sdk", - "version": "0.1.0-alpha.8", + "version": "0.1.0-alpha.9", "license": "Apache-2.0", "dependencies": { "@superset-ui/switchboard": "^0.18.26-0", diff --git a/superset-embedded-sdk/package.json b/superset-embedded-sdk/package.json index 055f44191a7e8..4ee8510a051af 100644 --- a/superset-embedded-sdk/package.json +++ b/superset-embedded-sdk/package.json @@ -1,6 +1,6 @@ { "name": "@superset-ui/embedded-sdk", - "version": "0.1.0-alpha.8", + "version": "0.1.0-alpha.9", "description": "SDK for embedding resources from Superset into your own application", "access": "public", "keywords": [