From fc171770fad504af3dd40db7a09492534f684ac4 Mon Sep 17 00:00:00 2001 From: Maxime Beauchemin Date: Tue, 20 Jun 2017 13:36:57 -0700 Subject: [PATCH] Adding missing dependency and linting webpack.js --- superset/assets/package.json | 2 ++ superset/assets/webpack.config.js | 23 +++++++++++------------ 2 files changed, 13 insertions(+), 12 deletions(-) diff --git a/superset/assets/package.json b/superset/assets/package.json index 24b0f2942f4d6..50667e20b1174 100644 --- a/superset/assets/package.json +++ b/superset/assets/package.json @@ -63,6 +63,7 @@ "prop-types": "^15.5.8", "react": "^15.5.1", "react-ace": "^5.0.1", + "react-addons-css-transition-group": "^15.6.0", "react-addons-shallow-compare": "^15.4.2", "react-alert": "^2.0.1", "react-bootstrap": "^0.31.0", @@ -124,6 +125,7 @@ "sinon": "^2.1.0", "style-loader": "^0.18.2", "transform-loader": "^0.2.3", + "uglifyjs-webpack-plugin": "^0.4.6", "url-loader": "^0.5.7", "webpack": "^2.3.3", "webpack-manifest-plugin": "1.1.0", diff --git a/superset/assets/webpack.config.js b/superset/assets/webpack.config.js index 829dd729a6c9b..be8c8c983b9cb 100644 --- a/superset/assets/webpack.config.js +++ b/superset/assets/webpack.config.js @@ -125,17 +125,16 @@ const config = { ], }; if (process.env.NODE_ENV === 'production') { - config.plugins.push( - // Using settings suggested in https://github.com/webpack/webpack/issues/537 - new webpack.optimize.UglifyJsPlugin({ - sourceMap: false, - minimize: true, - compress: { - drop_debugger: true, - warnings: false, - drop_console: true, - }, - }), - ); + // Using settings suggested in https://github.com/webpack/webpack/issues/537 + const UJSplugin = new webpack.optimize.UglifyJsPlugin({ + sourceMap: false, + minimize: true, + compress: { + drop_debugger: true, + warnings: false, + drop_console: true, + }, + }); + config.plugins.push(UJSplugin); } module.exports = config;