Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INKVConnInternal::do_io_*: handle null buffer #11789

Merged

Commits on Sep 24, 2024

  1. INKVConnInternal::do_io_*: handle null buffer

    It's common for users of VC's to cancel io via a 0 byte, nullptr read or
    write on the VC. INKVConnInternal::do_io_read and
    INKVConnInternal::do_io_write were not prepared to handle such
    cancellations. This updates them to handle this gracefully rather than
    crashing on a nullptr dereference. This change is was found to be needed
    for the multiplexer plugin for handling HttpTunnel aborts.
    
    For reference, see, for example, UnixNetVConnection::do_io_read which
    handles a nullptr MIOBuffer. This basically copies that logic into
    INKVConnInternal so it handles cancellation gracefully.
    bneradt committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    7afd9e3 View commit details
    Browse the repository at this point in the history