From a9ea2c2e2f17726185ad12bf30fc6c21096fbcd1 Mon Sep 17 00:00:00 2001 From: "Alan M. Carroll" Date: Tue, 23 Apr 2019 02:33:31 -0500 Subject: [PATCH] cppcheck: Removed problematic move operators for FixedBufferWriter. (cherry picked from commit 7bef557ab8b46fa87eb8e9b4d9e906e3d6fd9145) --- include/tscore/BufferWriter.h | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/include/tscore/BufferWriter.h b/include/tscore/BufferWriter.h index d3731995279..b2c6873e3a6 100644 --- a/include/tscore/BufferWriter.h +++ b/include/tscore/BufferWriter.h @@ -207,6 +207,9 @@ class BufferWriter }; /** A @c BufferWrite concrete subclass to write to a fixed size buffer. + * + * Copies and moves are forbidden because that leaves the original in a potentially bad state. An + * instance is cheap to construct and should be done explicitly when needed. */ class FixedBufferWriter : public BufferWriter { @@ -231,10 +234,8 @@ class FixedBufferWriter : public BufferWriter FixedBufferWriter(const FixedBufferWriter &) = delete; FixedBufferWriter &operator=(const FixedBufferWriter &) = delete; - /// Move constructor. - FixedBufferWriter(FixedBufferWriter &&) = default; - /// Move assignment. - FixedBufferWriter &operator=(FixedBufferWriter &&) = default; + FixedBufferWriter(FixedBufferWriter &&) = delete; + FixedBufferWriter &operator=(FixedBufferWriter &&) = delete; FixedBufferWriter(MemSpan &span) : _buf(span.begin()), _capacity(static_cast(span.size())) {}