From 78d594253c97b8eb2b7f86203621fe451b75d5a3 Mon Sep 17 00:00:00 2001 From: John Rushford Date: Wed, 18 Dec 2019 17:28:40 +0000 Subject: [PATCH] LGTM: fix a comparison that is always false. Fixes a comparison error in NextHopSelectionStrategy::markNextHopUp() that prevents a host restoral message from being logged. --- proxy/http/remap/NextHopSelectionStrategy.cc | 3 --- 1 file changed, 3 deletions(-) diff --git a/proxy/http/remap/NextHopSelectionStrategy.cc b/proxy/http/remap/NextHopSelectionStrategy.cc index 99be984b7f9..a101dfe818e 100644 --- a/proxy/http/remap/NextHopSelectionStrategy.cc +++ b/proxy/http/remap/NextHopSelectionStrategy.cc @@ -267,7 +267,6 @@ NextHopSelectionStrategy::markNextHopDown(const uint64_t sm_id, ParentResult &re void NextHopSelectionStrategy::markNextHopUp(const uint64_t sm_id, ParentResult &result) { - uint32_t old_count = 0; // Make sure that we are being called back with with a // result structure with a parent that is being retried ink_assert(result.retry == true); @@ -286,8 +285,6 @@ NextHopSelectionStrategy::markNextHopUp(const uint64_t sm_id, ParentResult &resu if (!h->available) { h->set_available(); - } - if (h->available && old_count > 0) { NH_Note("[%" PRIu64 "] http parent proxy %s:%d restored", sm_id, h->hostname.c_str(), h->getPort(scheme)); } }