From 97dffcd7d7282d2cc07cfd3dabfaa24af62bb9a5 Mon Sep 17 00:00:00 2001 From: Thomas Jackson Date: Mon, 18 Jul 2016 09:13:03 -0700 Subject: [PATCH] TS-4674: Remove useless assert statement Now that we have clean allocations (instead of clobbering existing things) there is no need to have this assertion. In practice this assertion is actually incorrect, because in the case where we want to extend the lifetime of a stale record (since the response we got was broken) we'll fail this assert. This closes #809 --- iocore/hostdb/HostDB.cc | 3 --- 1 file changed, 3 deletions(-) diff --git a/iocore/hostdb/HostDB.cc b/iocore/hostdb/HostDB.cc index 26810d97156..b12f20c1938 100644 --- a/iocore/hostdb/HostDB.cc +++ b/iocore/hostdb/HostDB.cc @@ -1332,9 +1332,6 @@ HostDBContinuation::dnsEvent(int event, HostEnt *e) r = lookup_done(md5.ip, e->ent.h_name, false, ttl_seconds, &e->srv_hosts, r); } - // @c lookup_done should always return a valid value so @a r should be null @c NULL. - ink_assert(r && r->app.allotment.application1 == 0 && r->app.allotment.application2 == 0); - // Conditionally make rr record entries if (is_rr) { r->app.rr.offset = offset;