From 9cca51570a81838aa57ceb19af535ea40798ff50 Mon Sep 17 00:00:00 2001 From: bneradt Date: Fri, 29 Apr 2022 15:44:18 -0500 Subject: [PATCH] Unit test compiler and library run time fixes This fixes a signed type warning and a library runtime warning in the unit (Catch) tests. --- iocore/net/quic/test/test_QUICPacket.cc | 3 ++- src/tscore/Makefile.am | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/iocore/net/quic/test/test_QUICPacket.cc b/iocore/net/quic/test/test_QUICPacket.cc index 35ffd5ea43c..b9125968e13 100644 --- a/iocore/net/quic/test/test_QUICPacket.cc +++ b/iocore/net/quic/test/test_QUICPacket.cc @@ -249,7 +249,8 @@ TEST_CASE("Sending Packet", "[quic]") CHECK(packet.is_crypto_packet()); packet.store(buf, &len); - CHECK(len == packet.size() - 16); + // See above packet.size() CHECK: packet.size must be greater than 16. + CHECK(len == static_cast(packet.size() - 16)); CHECK(memcmp(buf, expected, len - 16) == 0); } diff --git a/src/tscore/Makefile.am b/src/tscore/Makefile.am index 3a6cdfbf8e0..878fbb187a9 100644 --- a/src/tscore/Makefile.am +++ b/src/tscore/Makefile.am @@ -38,7 +38,7 @@ AM_CPPFLAGS += \ $(TS_INCLUDES) \ @YAMLCPP_INCLUDES@ -libtscore_la_LDFLAGS = -no-undefined -version-info @TS_LIBTOOL_VERSION@ @YAMLCPP_LDFLAGS@ +libtscore_la_LDFLAGS = @AM_LDFLAGS@ -no-undefined -version-info @TS_LIBTOOL_VERSION@ @YAMLCPP_LDFLAGS@ libtscore_la_LIBADD = \ $(top_builddir)/src/tscpp/util/libtscpputil.la \ @HWLOC_LIBS@ \