From 507d56b75ecff7369bf4472945d6f7b1d4e3bd54 Mon Sep 17 00:00:00 2001 From: Zhi Chen Date: Mon, 14 Oct 2019 00:43:34 +0000 Subject: [PATCH] Address comments --- include/tvm/runtime/vm.h | 7 ++++--- src/runtime/vm/executable.cc | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/include/tvm/runtime/vm.h b/include/tvm/runtime/vm.h index a12971fb0b46f..f02365e16a0c7 100644 --- a/include/tvm/runtime/vm.h +++ b/include/tvm/runtime/vm.h @@ -366,7 +366,7 @@ struct VMFrame { /*! \brief The executable emitted by the VM compiler. * * The executable contains information (e.g. data in different memory regions) - * to create a virtual machine. + * to run in a virtual machine. */ class Executable : public ModuleNode { public: @@ -382,7 +382,7 @@ class Executable : public ModuleNode { const std::shared_ptr& sptr_to_self) final; /*! - * \brief Get the serialized form of the `functions` in `vm_`. This is + * \brief Get the serialized form of the `functions`. This is * essentially bytecode serialization. * * \return The serialized vm bytecode. @@ -433,7 +433,8 @@ class Executable : public ModuleNode { return "VMExecutable"; } - /*! \brief The runtime module/library that contains hardware dependent code. */ + /*! \brief The runtime module/library that contains both the host and also the device + * code when executing on non-CPU devices. */ runtime::Module lib; /*! \brief The global constant pool. */ std::vector constants; diff --git a/src/runtime/vm/executable.cc b/src/runtime/vm/executable.cc index 9d55ec40b095f..197f57876e465 100644 --- a/src/runtime/vm/executable.cc +++ b/src/runtime/vm/executable.cc @@ -87,7 +87,7 @@ std::string Executable::GetBytecode() const { << func.instructions.size() << std::endl; // Print pramams of a `VMFunction`. - oss << "# Parameters:"<< std::endl; + oss << "# Parameters: "<< std::endl; for (const auto& param : func.params) { oss << param << " "; }