[Bugfix] Allow import of TVM when current directory is read-only #17142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, TVM could only be imported if the current directory had write privileges. This was due to the use of `tvm.contrib.pickle_memoize` to cache the winograd transformation matrices. This commit makes multiple related fixes, to ensure that (1) TVM can be imported regardless of directory permissions, (2) the working directory is not left in a cluttered state, and (3) cache files are generated in an expected location to be reused later. * The cache directory is only generated when required, just prior to saving a cache. * The cache directory defaults to `$HOME/.cache/tvm/pkl_memoize`, rather than `.pkl_memorize_py3` in the working directory. * The cache directory respects `XDG_CACHE_HOME`, using `$XDG_CACHE_HOME/tvm/pkl_memoize` if set.
Lunderberg
force-pushed
the
bugfix_import_tvm_in_read_only_dir
branch
from
4aa3d74
to
110314b
Compare
vinx13
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, TVM could only be imported if the current directory had write privileges. This was due to the use of
tvm.contrib.pickle_memoizeto cache the winograd transformation matrices.This commit makes multiple related fixes, to ensure that (1) TVM can be imported regardless of directory permissions, (2) the working directory is not left in a cluttered state, and (3) cache files are generated in an expected location to be reused later.
The cache directory is only generated when required, just prior to saving a cache.
The cache directory defaults to
$HOME/.cache/tvm/pkl_memoize, rather than.pkl_memorize_py3in the working directory.The cache directory respects
XDG_CACHE_HOME, using$XDG_CACHE_HOME/tvm/pkl_memoizeif set.