Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TOPI] Enable scatter_add on GPU #6856

Merged
merged 5 commits into from
Nov 5, 2020
Merged

Conversation

masahi
Copy link
Member

@masahi masahi commented Nov 5, 2020

This adds support for running scatter_add op on GPU, building on #6533
Hand written IRs developed by @mbrookhart are reused.

please review @mbrookhart @zhiics @kevinthesun
cc @interesaaat

Copy link
Contributor

@mbrookhart mbrookhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good idea on the update func. Maybe we could simplify the cpu kernels with a similar trick.

@zhiics zhiics merged commit 7ee91da into apache:main Nov 5, 2020
@zhiics
Copy link
Member

zhiics commented Nov 5, 2020

Thanks @masahi @mbrookhart @tqchen

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Dec 2, 2020
* enable scatter gpu test on cuda

* adding update_func arg

* pytorch scatter_add gpu tests working

* update 3d and 4d scatter

* enable scatter_add gpu test

Co-authored-by: masa <masa@pop-os.localdomain>
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Dec 4, 2020
* enable scatter gpu test on cuda

* adding update_func arg

* pytorch scatter_add gpu tests working

* update 3d and 4d scatter

* enable scatter_add gpu test

Co-authored-by: masa <masa@pop-os.localdomain>
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Dec 4, 2020
* enable scatter gpu test on cuda

* adding update_func arg

* pytorch scatter_add gpu tests working

* update 3d and 4d scatter

* enable scatter_add gpu test

Co-authored-by: masa <masa@pop-os.localdomain>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants