[FRONTEND][ONNX] Remove seemingly invalid SoftPlus #7189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `Softplus` is added in 12/10/2020 from this apache#7089 - However, I see that there were `SoftPlus` (not the P is in capital) was already in. According to [Onnx spec](https://github.com/onnx/onnx/blob/master/docs/Operators.md), it is `Softplus` not `SoftPlus`.
|
I didn’t notice that either. Thank you for the PR! |
junrushao
approved these changes
Jan 3, 2021
insop
changed the title
tkonolige
pushed a commit
to tkonolige/incubator-tvm
that referenced
this pull request
Jan 11, 2021
- `Softplus` is added in 12/10/2020 from this apache#7089 - However, I see that there were `SoftPlus` (not the P is in capital) was already in. According to [Onnx spec](https://github.com/onnx/onnx/blob/master/docs/Operators.md), it is `Softplus` not `SoftPlus`.
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Jan 20, 2021
- `Softplus` is added in 12/10/2020 from this apache#7089 - However, I see that there were `SoftPlus` (not the P is in capital) was already in. According to [Onnx spec](https://github.com/onnx/onnx/blob/master/docs/Operators.md), it is `Softplus` not `SoftPlus`.
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jan 21, 2021
- `Softplus` is added in 12/10/2020 from this apache#7089 - However, I see that there were `SoftPlus` (not the P is in capital) was already in. According to [Onnx spec](https://github.com/onnx/onnx/blob/master/docs/Operators.md), it is `Softplus` not `SoftPlus`.
electriclilies
pushed a commit
to electriclilies/tvm
that referenced
this pull request
Feb 18, 2021
- `Softplus` is added in 12/10/2020 from this apache#7089 - However, I see that there were `SoftPlus` (not the P is in capital) was already in. According to [Onnx spec](https://github.com/onnx/onnx/blob/master/docs/Operators.md), it is `Softplus` not `SoftPlus`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue discussed in #7176
Softplusis added in 12/10/2020 from this [Relay][Frontend][Onnx] Add softplus operator conversion to Onnx. #7089SoftPlus(note the P is in capital) was already in.According to Onnx spec, it is
SoftplusnotSoftPlus.@jwfromm, @junrushao1994