Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend][MXNet] Add support for MXNet GroupNorm #7409

Merged
merged 3 commits into from
Feb 13, 2021

Conversation

trevor-m
Copy link
Contributor

@trevor-m trevor-m commented Feb 4, 2021

Supports the GroupNorm op in mxnet frontend.

Since MXNet's groupnorm implementation is bugged when num_groups != num_channels, I disabled a few unit tests for now. MXNet fixed the bugs in MXNet 2.0 apache/mxnet#18199

@trevor-m
Copy link
Contributor Author

@junrushao1994 @kevinthesun @icemelon9 Could you please review?

Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@junrushao
Copy link
Member

CC: @sxjscience if you would like a second look. Thanks!

@sxjscience
Copy link
Member

This looks good to me.

@junrushao junrushao merged commit 2e6e7dc into apache:main Feb 13, 2021
Lokiiiiii pushed a commit to Lokiiiiii/tvm that referenced this pull request Mar 2, 2021
* Add support for MXNet GroupNorm

* Fix python lint

* Fix lint
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Mar 2, 2021
* Add support for MXNet GroupNorm

* Fix python lint

* Fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants