[TVMC] Compose target options from target registry #9218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `test_tvmc_common.py` file was becoming a bit of a mixed bag of tests and as we now want to extend the `Target` processing logic it made sense to split each out into its own file to make it clearer what each does. `test_common.py` has also been renamed before we start using it for all the tests instead.
Mousius
requested review from
areusch,
comaniac,
jroesch,
junrushao,
jwfromm,
kparzysz-quic,
leandron,
masahi,
merrymercy,
tqchen,
vinx13,
yzhliu and
ZihengJiang
as code owners
[The RFC for this is still under discussion](https://github.com/apache/tvm-rfcs/pulls), but doing this before splitting the registries makes the most sense. This enables the `tvmc` driver to re-combobulate Target options from arguments: ``` tvmc --target=llvm \ --target-llvm-mcpu=cortex-m3 ```
Mousius
force-pushed
the
tvmc-target-options
branch
from
5bcae99 to
9c07311
Compare
This was referenced Oct 11, 2021
areusch
approved these changes
Oct 12, 2021
| @@ -0,0 +1,74 @@ | |||
| # Licensed to the Apache Software Foundation (ASF) under one | |||
There was a problem hiding this comment.
should target_from_cli move here?
There was a problem hiding this comment.
Yip, I didn't realise test_common.py matched with common.py, so there'll be another PR at some point to split out the mixed set of things in common.py.
| # We can't tell the type inside an Array but all current options are strings so | ||
| # it can default to that. Bool is used alongside Integer but aren't distinguished | ||
| # between as both are represented by IntImm | ||
| INTERNAL_TO_NATIVE_TYPE = {"runtime.String": str, "IntImm": int, "Array": str} |
There was a problem hiding this comment.
this is kind of unfortunate but i see there isn't really much way around it right now without a very large refactor.
masahi
pushed a commit
to Laurawly/tvm-1
that referenced
this pull request
Oct 14, 2021
* [TVMC] Split common tvmc test file into more specific files The `test_tvmc_common.py` file was becoming a bit of a mixed bag of tests and as we now want to extend the `Target` processing logic it made sense to split each out into its own file to make it clearer what each does. `test_common.py` has also been renamed before we start using it for all the tests instead. * [TVMC] Compose target options from target registry [The RFC for this is still under discussion](https://github.com/apache/tvm-rfcs/pulls), but doing this before splitting the registries makes the most sense. This enables the `tvmc` driver to re-combobulate Target options from arguments: ``` tvmc --target=llvm \ --target-llvm-mcpu=cortex-m3 ```
This was referenced Oct 19, 2021
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
* [TVMC] Split common tvmc test file into more specific files The `test_tvmc_common.py` file was becoming a bit of a mixed bag of tests and as we now want to extend the `Target` processing logic it made sense to split each out into its own file to make it clearer what each does. `test_common.py` has also been renamed before we start using it for all the tests instead. * [TVMC] Compose target options from target registry [The RFC for this is still under discussion](https://github.com/apache/tvm-rfcs/pulls), but doing this before splitting the registries makes the most sense. This enables the `tvmc` driver to re-combobulate Target options from arguments: ``` tvmc --target=llvm \ --target-llvm-mcpu=cortex-m3 ```
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* [TVMC] Split common tvmc test file into more specific files The `test_tvmc_common.py` file was becoming a bit of a mixed bag of tests and as we now want to extend the `Target` processing logic it made sense to split each out into its own file to make it clearer what each does. `test_common.py` has also been renamed before we start using it for all the tests instead. * [TVMC] Compose target options from target registry [The RFC for this is still under discussion](https://github.com/apache/tvm-rfcs/pulls), but doing this before splitting the registries makes the most sense. This enables the `tvmc` driver to re-combobulate Target options from arguments: ``` tvmc --target=llvm \ --target-llvm-mcpu=cortex-m3 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RFC for this is still under discussion, but doing this before splitting the registries makes the most sense. This enables the
tvmcdriver to re-combobulate Target options from arguments:This rolls in #9206 so you may want to just look at the second commit.