Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5/10] Code generation for Depthwise Convolution via CMSIS-NN #9409

Merged
merged 3 commits into from
Nov 26, 2021
Merged

[5/10] Code generation for Depthwise Convolution via CMSIS-NN #9409

merged 3 commits into from
Nov 26, 2021

Conversation

ashutosh-arm
Copy link
Contributor

@ashutosh-arm ashutosh-arm commented Nov 1, 2021 •
edited
Loading

This PR adds support for depthwise convolution via CMSIS-NN.

Here is the tracking issue: #8646

This is blocked on #9331 which is dependent on #9296.

@ashutosh-arm
Copy link
Contributor Author

cc: @grant-arm @Mousius @areusch for code review.

@ashutosh-arm ashutosh-arm mentioned this pull request Nov 1, 2021
Closed
manupak
manupak reviewed Nov 18, 2021
View reviewed changes
Copy link
Contributor

@manupak manupak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broadly looks good.
nits and a question.

src/relay/backend/contrib/cmsisnn/generate_constants.cc Outdated Show resolved Hide resolved
tests/python/contrib/test_cmsisnn/test_conv2d.py Outdated Show resolved Hide resolved
Mousius
Mousius requested changes Nov 18, 2021
View reviewed changes
Copy link
Member

@Mousius Mousius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall makes sense to me, I've suggested a few things but I don't think any of them are blocking.

src/relay/backend/contrib/cmsisnn/generate_constants.cc Outdated Show resolved Hide resolved
src/relay/backend/contrib/cmsisnn/relay_to_tir.cc Show resolved Hide resolved
src/relay/backend/contrib/cmsisnn/tir_to_runtime.cc Outdated Show resolved Hide resolved
tests/python/contrib/test_cmsisnn/test_conv2d.py Outdated Show resolved Hide resolved
@ashutosh-arm ashutosh-arm mentioned this pull request Nov 18, 2021
Merged
@ashutosh-arm
Code generation for Conv2D via CMSIS-NN
07fa98a 
Change-Id: I0a2279965a0b505f809ffcf8b955f64db8f4aff0
@ashutosh-arm
code review: tests for new passes, clean up of relay_to_tir for cmsis-nn
d5eb75a 
Change-Id: Icd9ae4d456a75761f476f8ae73bff64d48e59dd5
@ashutosh-arm
Code generation for Depthwise Conv2D via CMSIS-NN
3ad4ba9 
Change-Id: Iac6acf1c310b20b9e99bf0b9c0310423c93de9be
manupak
manupak approved these changes Nov 25, 2021
View reviewed changes
Copy link
Contributor

@manupak manupak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Mousius
Mousius approved these changes Nov 25, 2021
View reviewed changes
Copy link
Member

@Mousius Mousius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Post fixing CI please 😸

@manupak manupak merged commit 52edc9a into apache:main Nov 26, 2021
@manupak
Copy link
Contributor

manupak commented Nov 26, 2021

Thanks! @ashutosh-arm @Mousius

dchauhan-arm pushed a commit to dchauhan-arm/tvm that referenced this pull request Nov 29, 2021
@ashutosh-arm @dchauhan-arm
[5/10] Code generation for Depthwise Convolution via CMSIS-NN (apache…
12f1ad8 
…#9409)

This PR adds support for depthwise convolution via CMSIS-NN.
masahi pushed a commit to masahi/tvm that referenced this pull request Dec 1, 2021
@ashutosh-arm @masahi
[5/10] Code generation for Depthwise Convolution via CMSIS-NN (apache…
af9a446 
…#9409)

This PR adds support for depthwise convolution via CMSIS-NN.
mehrdadh pushed a commit to mehrdadh/tvm that referenced this pull request Dec 1, 2021
@ashutosh-arm @mehrdadh
[5/10] Code generation for Depthwise Convolution via CMSIS-NN (apache…
3c094d2 
…#9409)

This PR adds support for depthwise convolution via CMSIS-NN.
mehrdadh pushed a commit to mehrdadh/tvm that referenced this pull request Dec 1, 2021
@ashutosh-arm @mehrdadh
[5/10] Code generation for Depthwise Convolution via CMSIS-NN (apache…
d20effb 
…#9409)

This PR adds support for depthwise convolution via CMSIS-NN.
@ashutosh-arm ashutosh-arm deleted the depthwise branch December 7, 2021 10:06
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 7, 2022
@ashutosh-arm @ylc
[5/10] Code generation for Depthwise Convolution via CMSIS-NN (apache…
69bfcc6 
…#9409)

This PR adds support for depthwise convolution via CMSIS-NN.
yangulei pushed a commit to yangulei/tvm that referenced this pull request Jan 11, 2022
@ashutosh-arm @yangulei
[5/10] Code generation for Depthwise Convolution via CMSIS-NN (apache…
e4596d4 
…#9409)

This PR adds support for depthwise convolution via CMSIS-NN.
yangulei pushed a commit to yangulei/tvm that referenced this pull request Jan 12, 2022
@ashutosh-arm @yangulei
[5/10] Code generation for Depthwise Convolution via CMSIS-NN (apache…
a254925 
…#9409)

This PR adds support for depthwise convolution via CMSIS-NN.
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
@ashutosh-arm @ylc
[5/10] Code generation for Depthwise Convolution via CMSIS-NN (apache…
1837d85 
…#9409)

This PR adds support for depthwise convolution via CMSIS-NN.
@driazati driazati mentioned this pull request Jul 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manupak manupak manupak approved these changes

@Mousius Mousius Mousius approved these changes

@anijain2305 anijain2305 Awaiting requested review from anijain2305

@areusch areusch Awaiting requested review from areusch

@comaniac comaniac Awaiting requested review from comaniac

@jroesch jroesch Awaiting requested review from jroesch

@junrushao junrushao Awaiting requested review from junrushao

@jwfromm jwfromm Awaiting requested review from jwfromm

@MarisaKirisame MarisaKirisame Awaiting requested review from MarisaKirisame

@mbaret mbaret Awaiting requested review from mbaret

@mbrookhart mbrookhart Awaiting requested review from mbrookhart

@merrymercy merrymercy Awaiting requested review from merrymercy

@slyubomirsky slyubomirsky Awaiting requested review from slyubomirsky

@tqchen tqchen Awaiting requested review from tqchen

@trevor-m trevor-m Awaiting requested review from trevor-m

@vinx13 vinx13 Awaiting requested review from vinx13

@wweic wweic Awaiting requested review from wweic

@yzhliu yzhliu Awaiting requested review from yzhliu

@zhiics zhiics Awaiting requested review from zhiics

@ZihengJiang ZihengJiang Awaiting requested review from ZihengJiang

@icemelon icemelon Awaiting requested review from icemelon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashutosh-arm @manupak @Mousius