Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default for split op #9489

Merged
merged 2 commits into from
Nov 11, 2021
Merged

Add default for split op #9489

merged 2 commits into from
Nov 11, 2021

Conversation

anwang2009
Copy link
Contributor

When the attr.split length is 1 or less, we should fall back to default split behavior -- dividing evenly over the axes, because the split importer drops the first item in the attr.split list. The shape func for split assumes at least one item in the split indices.

@mbrookhart
Copy link
Contributor

Can you add a test that hits this case? Otherwise LGTM

@junrushao junrushao merged commit 1e09bb2 into apache:main Nov 11, 2021
AndrewZhaoLuo added a commit to AndrewZhaoLuo/tvm that referenced this pull request Nov 12, 2021
* main: (119 commits)
  [Topi][Op][PyTorch][Vitas] Fix inconsistent kernel layout conventions for conv2d_transpose (apache#9336)
  Fix repository URL in ubuntu_install_rocm.sh (apache#9425)
  Add LLVM-13 installation to Docker setup (apache#9498)
  [Relay] Use target_host determined at Relay level instead of recalculating it (apache#9499)
  Arm(R) Ethos(TM)-U NPU BinaryElementwise operators support (apache#9442)
  [COMMUNITY] Junru's and Wuwei's PGP key for ASF release (apache#9488)
  Add default for split op (apache#9489)
  [HOTFIX][TARGET] Change LOG in compilation config to DLOG (apache#9486)
  Fixed some warnings about lambda's closures that are bigger than necessary (apache#9481)
  [Support] Add libinfo into the runtime build (apache#9310)
  Change Call with TIRCallAttrs to call_lowered op (apache#9312)
  [ETHOSN] Streamline Ethos(TM)-N cross-compile rpc usage (apache#9477)
  [CMSIS-NN] Assert correct amount of CMSIS-NN artifacts in MLF (apache#9480)
  [MicroTVM][PyTest] Explicitly skip MicroTVM unittests. (apache#9335)
  [microNPU] Replace ICHECK with diagnostic context in type inference (apache#9470)
  Better host handling in CompilationConfig & debug printing (apache#9460)
  [AOT][Tests] Use pre-built libraries in Reference System tests (apache#9271)
  [TIR] Add type hint for TIR  (apache#9432)
  [TVMC] Add test for quantized pytorch model (apache#9467)
  [CMSIS-NN] Convert CMSIS-NN to use Target Hooks (apache#9397)
  ...
mehrdadh pushed a commit to mehrdadh/tvm that referenced this pull request Dec 1, 2021
* split fix

* add default split test case
mehrdadh pushed a commit to mehrdadh/tvm that referenced this pull request Dec 1, 2021
* split fix

* add default split test case
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 7, 2022
* split fix

* add default split test case
yangulei pushed a commit to yangulei/tvm that referenced this pull request Jan 11, 2022
* split fix

* add default split test case
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
* split fix

* add default split test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants