Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support addon index #35

Merged
merged 11 commits into from
Nov 16, 2023
Merged

feat: support addon index #35

merged 11 commits into from
Nov 16, 2023

Conversation

1aal
Copy link
Contributor

@1aal 1aal commented Nov 13, 2023 •
edited
Loading

kbcli addon index support:

  1. add: add a new addon index eg: kbcli addon index add kubeblocks https://github.com/apecloud/block-index.git
  2. delete: delete an addon index eg: kbcli addon index delete kubeblocks
  3. update: update the specified index(es) eg:kbcli addon index update kubeblocks
  4. list: list all addon index eg: kbcli addon index list

image

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Nov 13, 2023
ldming
ldming reviewed Nov 14, 2023
View reviewed changes
pkg/util/gitutil/git.go Outdated Show resolved Hide resolved
pkg/cmd/addon/addon.go Outdated Show resolved Hide resolved
pkg/cmd/addon/index.go Show resolved Hide resolved
pkg/cmd/addon/index.go Outdated Show resolved Hide resolved
pkg/cmd/addon/index.go Outdated Show resolved Hide resolved
pkg/cmd/addon/index.go Outdated Show resolved Hide resolved
pkg/cmd/addon/index.go Outdated Show resolved Hide resolved
pkg/cmd/addon/index.go Outdated Show resolved Hide resolved
pkg/cmd/addon/index.go Outdated Show resolved Hide resolved
pkg/types/types.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2023 •
edited
Loading

Codecov Report

Attention: 187 lines in your changes are missing coverage. Please review.

Comparison is base (ab2f4e5) 43.08% compared to head (765326f) 42.89%.
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/cmd/addon/index.go 25.22% 158 Missing and 5 partials ⚠️
pkg/util/util.go 0.00% 15 Missing ⚠️
pkg/util/git.go 0.00% 9 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
- Coverage   43.08%   42.89%   -0.19%     
==========================================
  Files         221      222       +1     
  Lines       28071    28313     +242     
==========================================
+ Hits        12093    12146      +53     
- Misses      14492    14676     +184     
- Partials     1486     1491       +5
Flag Coverage Δ
unittests 42.89% <23.04%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ldming
ldming reviewed Nov 15, 2023
View reviewed changes
pkg/types/types.go Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
pkg/cmd/addon/index.go Outdated Show resolved Hide resolved
pkg/cmd/addon/index.go Outdated Show resolved Hide resolved
pkg/cmd/addon/index.go Outdated Show resolved Hide resolved
pkg/types/types.go Outdated Show resolved Hide resolved
ldming
ldming reviewed Nov 15, 2023
View reviewed changes
pkg/cmd/addon/index.go Outdated
Use: "add",
Short: "Add a new addon index",
Long: "Configure a new index to install KubeBlocks addon from.",
Example: "kbcli index add kubeblocks " + types.DefaultAddonIndexURL,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example should be kbcli addon index add kubeblocks ...

pkg/cmd/addon/index.go Outdated
Use: "update",
Short: "update the specified index(es)",
Long: "Update existed index repository from index origin URL",
Example: "kbcli index update KubeBlocks",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kbcli addon index update KubeBlocks

docs/user_docs/cli/kbcli_addon.md
@@ -40,6 +40,7 @@ Addon command.
* [kbcli addon describe](kbcli_addon_describe.md) - Describe an addon specification.
* [kbcli addon disable](kbcli_addon_disable.md) - Disable an addon.
* [kbcli addon enable](kbcli_addon_enable.md) - Enable an addon.
* [kbcli addon index](kbcli_addon_index.md) - Manage custom addon indexes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the kbcli_addon_index.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the kbcli_addon_index.md

Due to the wrong usage, the user documentation was not generated automatically. I have made the adjustments.

@github-actions github-actions bot added size/XL Denotes a PR that changes 500-999 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Nov 15, 2023
@ldming ldming merged commit 43c3b87 into main Nov 16, 2023
9 checks passed
@ldming ldming deleted the support/addon-list branch November 16, 2023 04:55
@github-actions github-actions bot added this to the Release 0.8.0 milestone Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldming ldming ldming approved these changes

@nayutah nayutah Awaiting requested review from nayutah nayutah is a code owner

@heng4fun heng4fun Awaiting requested review from heng4fun heng4fun is a code owner

@free6om free6om Awaiting requested review from free6om free6om is a code owner

@wangyelei wangyelei Awaiting requested review from wangyelei wangyelei is a code owner

@leon-inf leon-inf Awaiting requested review from leon-inf leon-inf is a code owner

Assignees
No one assigned
Labels
size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Milestone
Release 0.8.0
Development

Successfully merging this pull request may close these issues.

[Features]support kbcli addon index
3 participants
@1aal @codecov-commenter @ldming