Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove new cluster conn-credential API #6098

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

leon-inf
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Dec 14, 2023
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (f1fa247) 68.42% compared to head (340ec0f) 68.55%.
Report is 13 commits behind head on main.

Files Patch % Lines
pkg/dataprotection/utils/utils.go 0.00% 12 Missing ⚠️
controllers/apps/transformer_cluster_credential.go 71.42% 4 Missing and 2 partials ⚠️
pkg/dataprotection/restore/manager.go 63.63% 3 Missing and 1 partial ⚠️
pkg/controller/component/vars.go 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6098      +/-   ##
==========================================
+ Coverage   68.42%   68.55%   +0.12%     
==========================================
  Files         295      295              
  Lines       33716    33619      -97     
==========================================
- Hits        23070    23046      -24     
+ Misses       8727     8647      -80     
- Partials     1919     1926       +7     
Flag Coverage Δ
unittests 68.55% <54.54%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nayutah
Copy link
Collaborator

nayutah commented Dec 18, 2023

This feature introduces API changes, which may incur compatibility problems, please make it clear in the manual books

@leon-inf
Copy link
Contributor Author

/approve

@apecloud-bot apecloud-bot added the approved PR Approved Test label Dec 18, 2023
@leon-inf leon-inf merged commit 794b49a into main Dec 18, 2023
77 checks passed
@leon-inf leon-inf deleted the support/remove-cluster-conn-credential branch December 18, 2023 13:22
@leon-inf
Copy link
Contributor Author

/cherry-pick release-0.8

@github-actions github-actions bot added this to the Release 0.8.0 milestone Dec 18, 2023
Copy link

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/7248687009

github-actions bot pushed a commit that referenced this pull request Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants