chore: keep role label when doing image in-place update #8406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangyelei
approved these changes
Nov 6, 2024
|
/approve |
apecloud-bot
approved these changes
Nov 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8406 +/- ##
==========================================
+ Coverage 61.05% 61.20% +0.14%
==========================================
Files 351 351
Lines 41803 41796 -7
==========================================
+ Hits 25524 25580 +56
+ Misses 13956 13914 -42
+ Partials 2323 2302 -21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zjx20
approved these changes
Nov 6, 2024
free6om
added a commit
that referenced
this pull request
Nov 6, 2024
(cherry picked from commit 42b9d0d)
wangyelei
pushed a commit
that referenced
this pull request
Nov 6, 2024
wangyelei
pushed a commit
that referenced
this pull request
Nov 11, 2024
(cherry picked from commit 42b9d0d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.