From 9ef86043455e2a741d3542f6eb16c8352d13f5af Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?K=C3=A9vin=20Dunglas?= Date: Thu, 22 Aug 2024 18:22:10 +0200 Subject: [PATCH] fix tests --- src/Laravel/Tests/JsonLdTest.php | 5 ++--- src/Laravel/workbench/app/Models/Book.php | 2 +- src/Laravel/workbench/database/factories/BookFactory.php | 2 +- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/Laravel/Tests/JsonLdTest.php b/src/Laravel/Tests/JsonLdTest.php index 0434daa4e4..cbf57f42f4 100644 --- a/src/Laravel/Tests/JsonLdTest.php +++ b/src/Laravel/Tests/JsonLdTest.php @@ -280,10 +280,9 @@ public function testHidden(): void public function testVisible(): void { - $response = $this->get('/api/posts', ['accept' => 'application/ld+json']); + $response = $this->get('/api/books', ['accept' => 'application/ld+json']); $response->assertStatus(200); $response->assertHeader('content-type', 'application/ld+json; charset=utf-8'); - dump($response->json()); - $response->assertJsonMissingPath('internalNote'); + $this->assertStringNotContainsString('internalNote', $response->getContent()); } } diff --git a/src/Laravel/workbench/app/Models/Book.php b/src/Laravel/workbench/app/Models/Book.php index 5552c18f36..070d94cf5b 100644 --- a/src/Laravel/workbench/app/Models/Book.php +++ b/src/Laravel/workbench/app/Models/Book.php @@ -33,7 +33,7 @@ class Book extends Model use HasFactory; use HasUlids; - //protected $visible = ['name', 'author', 'isbn', 'publication_date']; + protected $visible = ['name', 'author', 'isbn', 'publication_date']; protected $fillable = ['name']; public function author(): BelongsTo diff --git a/src/Laravel/workbench/database/factories/BookFactory.php b/src/Laravel/workbench/database/factories/BookFactory.php index e775515a38..65af45ad5a 100644 --- a/src/Laravel/workbench/database/factories/BookFactory.php +++ b/src/Laravel/workbench/database/factories/BookFactory.php @@ -37,7 +37,7 @@ public function definition(): array 'author_id' => AuthorFactory::new(), 'isbn' => fake()->isbn13(), 'publication_date' => fake()->optional()->date(), - 'internal_note' => fake()->optional()->text(), + 'internal_note' => fake()->text(), ]; } }