feat(graphql): Handle multiple subscriptions per resource and issue updates to them all

Author: psihius

src/GraphQl/State/Processor/SubscriptionProcessor.php

@@ -33,7 +33,7 @@ public function __construct(private readonly ProcessorInterface $decorated, priv
     public function process(mixed $data, Operation $operation, array $uriVariables = [], array $context = [])
     {
         $data = $this->decorated->process($data, $operation, $uriVariables, $context);
-        if (!$operation instanceof GraphQlOperation || !($mercure = $operation->getMercure())) {
+        if (!$operation instanceof Subscription || !($mercure = $operation->getMercure())) {
             return $data;
         }
 

src/GraphQl/Subscription/SubscriptionManager.php

@@ -131,7 +131,7 @@ private function encodeIriToCacheKey(string $iri): string
     private function getResourceId(mixed $privateField, object $previousObject): string
     {
         $id = $previousObject->{'get'.ucfirst($privateField)}()->getId();
-        if ($id instanceof \Stringable) {
+        if ($id instanceof \Stringable || is_numeric($id)) {
             return (string) $id;
         }
 
@@ -149,39 +149,61 @@ private function getCreatedOrUpdatedPayloads(object $object): array
         $resourceMetadata = $this->resourceMetadataCollectionFactory->create($resourceClass);
         $shortName = $resourceMetadata->getOperation()->getShortName();
 
-        $mercure = $resourceMetadata->getOperation()->getMercure() ?? false;
-        $private = $mercure['private'] ?? false;
-        $privateFieldsConfig = $mercure['private_fields'] ?? [];
-        $privateFieldData = [];
-        if ($private && $privateFieldsConfig) {
-            foreach ($privateFieldsConfig as $privateField) {
-                $privateFieldData['__private_field_'.$privateField] = $this->getResourceId($privateField, $object);
-            }
-        }
-
-        $iri = $this->iriConverter->getIriFromResource($object);
-        // Add collection subscriptions
-        $subscriptions = array_merge(
-            $this->getSubscriptionsFromIri($this->getCollectionIri($iri), $privateFieldData),
-            $this->getSubscriptionsFromIri($iri)
-        );
-
         $payloads = [];
-        foreach ($subscriptions as [$subscriptionId, $subscriptionFields, $subscriptionResult]) {
-            if ($privateFieldData) {
-                $fieldDiff = array_intersect_assoc($subscriptionFields, $privateFieldData);
-                if ($fieldDiff !== $privateFieldData) {
+        foreach ($resourceMetadata as $apiResource) {
+            foreach ($apiResource->getGraphQlOperations() as $operation) {
+                if (!$operation instanceof Subscription) {
                     continue;
                 }
-            }
-            $resolverContext = ['fields' => $subscriptionFields, 'is_collection' => false, 'is_mutation' => false, 'is_subscription' => true];
-            $operation = (new Subscription())->withName('mercure_subscription')->withShortName($shortName);
-            $data = $this->normalizeProcessor->process($object, $operation, [], $resolverContext);
-
-            unset($data['clientSubscriptionId']);
+                $mercure = $resourceMetadata->getOperation()->getMercure() ?? false;
+                $operationMercure = $operation->getMercure() ?? false;
+                if ($mercure !== false && $operationMercure !== false) {
+                    /** @noinspection SlowArrayOperationsInLoopInspection */
+                    $mercure = array_merge($mercure, $operationMercure);
+                }
+                $private = $mercure['private'] ?? false;
+                $privateFieldsConfig = $mercure['private_fields'] ?? [];
+                $privateFieldData = [];
+                if ($private && $privateFieldsConfig) {
+                    foreach ($privateFieldsConfig as $privateField) {
+                        $privateFieldData['__private_field_' . $privateField] = $this->getResourceId(
+                            $privateField,
+                            $object
+                        );
+                    }
+                }
 
-            if ($data !== $subscriptionResult) {
-                $payloads[] = [$subscriptionId, $data];
+                $iri = $this->iriConverter->getIriFromResource($object);
+                // Add collection subscriptions
+                $subscriptions = array_merge(
+                    $this->getSubscriptionsFromIri($this->getCollectionIri($iri), $privateFieldData),
+                    $this->getSubscriptionsFromIri($iri)
+                );
+
+                foreach ($subscriptions as [$subscriptionId, $subscriptionFields, $subscriptionResult]) {
+                    if ($privateFieldData) {
+                        $fieldDiff = array_intersect_assoc($subscriptionFields, $privateFieldData);
+                        if ($fieldDiff !== $privateFieldData) {
+                            continue;
+                        }
+                    }
+                    $resolverContext = [
+                        'fields'          => $subscriptionFields,
+                        'is_collection'   => false,
+                        'is_mutation'     => false,
+                        'is_subscription' => true
+                    ];
+                    $subscriptionOperation = (new Subscription())->withName('mercure_subscription')->withShortName(
+                        $shortName
+                    );
+                    $data = $this->normalizeProcessor->process($object, $subscriptionOperation, [], $resolverContext);
+
+                    unset($data['clientSubscriptionId']);
+
+                    if ($data !== $subscriptionResult) {
+                        $payloads[] = [$subscriptionId, $data];
+                    }
+                }
             }
         }
 

src/Symfony/Doctrine/EventListener/PublishMercureUpdatesListener.php

@@ -336,7 +336,7 @@ private function buildUpdate(string|array $iri, string $data, array $options): U
     private function getResourceId(string $privateField, object $object): string
     {
         $id = $object->{'get'.ucfirst($privateField)}()->getId();
-        if ($id instanceof \Stringable) {
+        if ($id instanceof \Stringable || is_numeric($id)) {
             return (string) $id;
         }