Refactor and merge YAML and XML loaders #837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simperfit
reviewed
Nov 8, 2016
src/Metadata/YamlExtractor.php
Outdated
| * | ||
| * @return array | ||
| */ | ||
| public function getResources(): array |
Contributor
There was a problem hiding this comment.
What do you think about splitting this methods ?
Member
Author
There was a problem hiding this comment.
It was a POC, but indeed, it's a good idea :)
dunglas
force-pushed
the
factory_refactoring
branch
from
391bdec to
25d5e0b
Compare
Simperfit
approved these changes
Nov 8, 2016
meyerbaptiste
requested changes
Nov 9, 2016
|
|
||
| <service id="api_platform.metadata.resource.metadata_factory.yaml" decorates="api_platform.metadata.resource.metadata_factory" class="ApiPlatform\Core\Metadata\Resource\Factory\YamlResourceMetadataFactory" decoration-priority="40" public="false"> | ||
| <argument type="collection" /> | ||
| <argument type="service" id="api_platform.metadata.extractor.yaml" /> |
Member
|
Nice, we need to do the same for XML! |
dunglas
changed the title
dunglas
force-pushed
the
factory_refactoring
branch
2 times, most recently
from
34509a7 to
834bda5
Compare
Member
Author
|
Ready for review. A lot of duplicated code has been removed. |
dunglas
changed the title
dunglas
force-pushed
the
factory_refactoring
branch
from
34ece54 to
9b4559f
Compare
Member
Author
|
There is still some work to do (in other PRs):
|
Member
|
As @teohhanhui said, I think we should keep the I won't have time to review today, maybe this we! |
Member
Author
|
Why? With the new implementation it's mandatory to have the class as key. It will just be duplicated data. |
meyerbaptiste
requested changes
Nov 10, 2016
| $attributes = []; | ||
| foreach ($resource->$elementName as $attribute) { | ||
| $value = isset($attribute->attribute[0]) ? $this->getAttributes($attribute, 'attribute') : (string) $attribute; | ||
| isset($attribute['name']) ? $attributes[(string) $attribute['name']] = $value : $attributes[] = $value; |
| use ApiPlatform\Core\Metadata\Property\PropertyNameCollection; | ||
|
|
||
| /** | ||
| * Creates a property name collection using an extractor.. |
Closed
dunglas
force-pushed
the
factory_refactoring
branch
3 times, most recently
from
ac00c11 to
d353e6f
Compare
dunglas
force-pushed
the
factory_refactoring
branch
from
d353e6f to
20a360e
Compare
meyerbaptiste
approved these changes
Nov 11, 2016
magarzon
pushed a commit
to magarzon/core
that referenced
this pull request
Feb 12, 2017
Refactor and merge YAML and XML loaders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drastically simplify the code, remove a lot of duplication and improve performances.
BC break: the class name is not the key of the definition.
Can you review this please @soyuka and @meyerbaptiste.