This repository has been archived by the owner on Nov 8, 2024. It is now read-only.
Refactor ensure DreddHooks::Server can be used as library #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensuring that the output doesn't get buffered is particularly relevant once the server is started because Dredd relies on it. In order to be able to start programatically a server in the best conditions, that step should be part of the server starting procedure. Using a buffered output while loading the hookfiles, on the other hand poses no particular problem.
Unless I'm wrong, declaring bundler as a dependency is superfluous (e.g. its version is not locked in the Gemfile).
gonzalo-bulnes
force-pushed
the
gonzalo-bulnes/refactor-ensure-server-can-be-used-as-library
branch
2 times, most recently
from
8e0b2d5
to
c349392
Compare
gonzalo-bulnes
force-pushed
the
gonzalo-bulnes/refactor-ensure-server-can-be-used-as-library
branch
from
c349392
to
94e0214
Compare
gonzalo-bulnes
deleted the
gonzalo-bulnes/refactor-ensure-server-can-be-used-as-library
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a developer
In order to provide multiple uses to my gem
I want its code to be usable without its command-line interface
See #5
I'll add no specific documentation for this yet. However, and example of the
DreddHooks::Serverusage can be found inDreddHooks::CLI.