Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add monthlyUsage() and limits() endpoints to UserClients #517

Merged

Conversation

tobice
Copy link
Contributor

@tobice tobice commented Feb 21, 2024

These endpoints have been around for some quite time and now we're exposing them via the JS client.

@github-actions github-actions bot added this to the 83rd sprint - Platform team milestone Feb 21, 2024
@github-actions github-actions bot added t-platform Issues with this label are in the ownership of the platform team. tested Temporary label used only programatically for some analytics. labels Feb 21, 2024
@tobice
Copy link
Contributor Author

tobice commented Feb 21, 2024

The data responses are quite big and so are the TypeScript interfaces. I honestly can't say they are 100% correct. I used ChatGPT to transform a sample API response into an interface and then I cross-checked it with the code base (e.g. all fields seem to be mandatory). But I might have missed something.

Once this is released, I'll extend integration tests in apify-core to make sure that all fields are populated.

@jirimoravcik
Copy link
Member

The data responses are quite big and so are the TypeScript interfaces. I honestly can't say they are 100% correct. I used ChatGPT to transform a sample API response into an interface and then I cross-checked it with the code base (e.g. all fields seem to be mandatory). But I might have missed something.

Once this is released, I'll extend integration tests in apify-core to make sure that all fields are populated.

Yeah, in the future, we want to have types in API and share them across our codebase, sadly, we're not there yet.

@tobice tobice merged commit 2767c8d into master Feb 22, 2024
6 checks passed
@tobice tobice deleted the tobik/feat/add-monthly-usage-and-limits-endpoints-to-user-client branch February 22, 2024 09:54
@drobnikj drobnikj added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-platform Issues with this label are in the ownership of the platform team. tested Temporary label used only programatically for some analytics. validated Issues that are resolved and their solutions fulfill the acceptance criteria.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants