From d66800892ea725ae821600e6865f0110c51b29a5 Mon Sep 17 00:00:00 2001
From: Calvin Cestari <calvin.cestari@gmail.com>
Date: Mon, 28 Oct 2024 16:36:09 -0700
Subject: [PATCH 1/3] Save logs on failure

---
 .github/workflows/release-check.yml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/.github/workflows/release-check.yml b/.github/workflows/release-check.yml
index 8bb33ec14..8bd31d45c 100644
--- a/.github/workflows/release-check.yml
+++ b/.github/workflows/release-check.yml
@@ -124,23 +124,27 @@ jobs:
       run: |
         npm install && npm test
     - name: Save xcodebuild logs
+      if: ${{ failure() }}
       uses: actions/upload-artifact@v3
       with:
         name: ${{ matrix.name }}-logs
         path: |
           DerivedData/Logs/Build
     - name: Save crash logs
+      if: ${{ failure() }}
       uses: actions/upload-artifact@v3
       with:
         name: ${{ matrix.name }}-crashes
         path: |
           ~/Library/Logs/DiagnosticReports
     - name: Zip Result Bundle
+      if: ${{ failure() }}
       shell: bash
       working-directory: TestResults
       run: |
         zip -r ResultBundle.zip ResultBundle.xcresult
     - name: Save test results
+      if: ${{ failure() }}
       uses: actions/upload-artifact@v3
       with:
         name: ${{ matrix.name }}-results

From 58b57a8d31bc39718af80d0534d1925935684503 Mon Sep 17 00:00:00 2001
From: Calvin Cestari <calvin.cestari@gmail.com>
Date: Mon, 28 Oct 2024 16:36:17 -0700
Subject: [PATCH 2/3] Add pagination tests

---
 .github/workflows/release-check.yml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/.github/workflows/release-check.yml b/.github/workflows/release-check.yml
index 8bd31d45c..adfe52e82 100644
--- a/.github/workflows/release-check.yml
+++ b/.github/workflows/release-check.yml
@@ -90,6 +90,12 @@ jobs:
             test-plan: Apollo-Codegen-CITestPlan
             name: Codegen Lib Unit Tests - macOS
             run-js-tests: true
+          # ApolloPagination Tests
+          - destination: platform=macOS,arch=x86_64
+            scheme: ApolloPaginationTests
+            test-plan: Apollo-PaginationTestPlan
+            name: ApolloPagination Unit Tests - macOS
+            run-js-tests: false
     name: ${{ matrix.name }}
     steps:
     - uses: maxim-lobanov/setup-xcode@v1

From b4cb12e972ff69ede951d08b3c593dbfaecdb336 Mon Sep 17 00:00:00 2001
From: Calvin Cestari <calvin.cestari@gmail.com>
Date: Mon, 28 Oct 2024 16:36:24 -0700
Subject: [PATCH 3/3] Clean up

---
 .github/workflows/release-check.yml | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/.github/workflows/release-check.yml b/.github/workflows/release-check.yml
index adfe52e82..af06d8623 100644
--- a/.github/workflows/release-check.yml
+++ b/.github/workflows/release-check.yml
@@ -103,11 +103,6 @@ jobs:
         xcode-version: ${{ env.XCODE_VERSION }}
     - name: Checkout Repo
       uses: actions/checkout@v3
-    # Caching for apollo-ios and apollo-ios-codegen SPM dependencies
-    # - uses: actions/cache@v3
-    #   with:
-    #     path: ./DerivedData/SourcePackages
-    #     key: ${{ runner.os }}-spm-${{ hashFiles('./apollo-ios/Package.resolved') }}-${{ hashFiles('./apollo-ios-codegen/Package.resolved') }}
     - name: Retrieve Build Cache
       uses: actions/cache@v3
       with: